third_party/WebKit/Source/core/frame/External.idl - Issue 2177123003: Move SearchProvider implementation into Blink and make it a no-op.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/frame/External.idl

Issue 2177123003: Move SearchProvider implementation into Blink and make it a no-op. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase one more test. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // TODO(ryanchung): Add Cast CRL Root here.	5 [NoInterfaceObject]

6 const unsigned char kCastCRLRootCaDer[] = {	6 interface External {

7 0x30,	7 void AddSearchProvider();

	8 void IsSearchProviderInstalled();
	jam 2016/07/26 17:04:55 this has an integer return value per the spec. ed this has an integer return value per the spec. edge returns 2 always after the depreciation, see the link in the blink-dev thread where they said that after a long discussion they decided on this value (i.e. search is set) so that websites don't spam users to change the default jam 2016/07/26 17:09:23 oh actually nvm, i see from your intent email that Show quoted text On 2016/07/26 17:04:55, jam wrote: > this has an integer return value per the spec. > > edge returns 2 always after the depreciation, see the link in the blink-dev > thread where they said that after a long discussion they decided on this value > (i.e. search is set) so that websites don't spam users to change the default oh actually nvm, i see from your intent email that the spec says no return value. dcheng 2016/07/27 00:18:38 Yeah, let me talk to domenic and see if he has any Show quoted text On 2016/07/26 17:09:23, jam wrote: > On 2016/07/26 17:04:55, jam wrote: > > this has an integer return value per the spec. > > > > edge returns 2 always after the depreciation, see the link in the blink-dev > > thread where they said that after a long discussion they decided on this value > > (i.e. search is set) so that websites don't spam users to change the default > > oh actually nvm, i see from your intent email that the spec says no return > value. Yeah, let me talk to domenic and see if he has any thoughts on this.
8 };	9 };

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/core/frame/External.h ('k') | third_party/WebKit/Source/core/frame/Window.idl » ('j') | no next file with comments »