MD Settings: Implementing a "no results" page.

MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming "SearchContext" class to "SearchRequest" and resolving search()
   promises with SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3cc76ff035eca6a47c8dfe31883a4b9978ee2432
Cr-Commit-Position: refs/heads/master@{#407856}

[dpapad, 2016-07-23 01:07:45]

Description was changed from

==========
WIP, signify whether any results were found.

BUG=630383
==========

to

==========
WIP, signify whether any results were found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-26 00:54:51]

Description was changed from

==========
WIP, signify whether any results were found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming SearchContext to SearchRequest and resolving search() promises with
   SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.


BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-26 01:05:37]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:06:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2016-07-26 01:06:31]

Description was changed from

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming SearchContext to SearchRequest and resolving search() promises with
   SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.


BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming SearchContext to SearchRequest and resolving search() promises with
   SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-26 01:07:07]

Description was changed from

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming SearchContext to SearchRequest and resolving search() promises with
   SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming "SearchContext" class to "SearchRequest" and resolving search()
   promises with SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-07-26 01:17:14]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-07-26 01:17:15]

Screenshot at http://imgur.com/a/vKd0q.

Regarding testing, I attempted to add tests for <settings-main> to ensure that
the "no results" page is shown/hidden as expected, but stumbled on an issue,
filed crbug.com/631281 for further investigation.

[commit-bot: I haz the power, 2016-07-26 02:08:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 02:08:05]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-07-26 02:39:31]

lgtm

https://codereview.chromium.org/2176743004/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2176743004/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/settings_main/settings_main.js:177: // Promise
error" in the console.
it's arguable that we should just resolve(null) or add a boolean in the
request's context (i.e. finished: false) rather than reject, IMO

[dpapad, 2016-07-26 17:19:58]

https://codereview.chromium.org/2176743004/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2176743004/diff/100001/chrome/browser/resourc...
chrome/browser/resources/settings/settings_main/settings_main.js:177: // Promise
error" in the console.
On 2016/07/26 at 02:39:31, Dan Beam wrote:
> it's arguable that we should just resolve(null) or add a boolean in the
request's context (i.e. finished: false) rather than reject, IMO

Done, added 'finished' boolean.

[dpapad, 2016-07-26 17:33:54]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-07-26 17:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2176743004/#ps120001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-07-26 17:34:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 18:31:19]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-26 18:32:49]

Description was changed from

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming "SearchContext" class to "SearchRequest" and resolving search()
   promises with SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Implementing a "no results" page.

Specifically:
 - Removing mechanism of observing SearchManager for now.
 - Replacing with a Promise that is returned from SearchManager#search().
 - Renaming "SearchContext" class to "SearchRequest" and resolving search()
   promises with SearchRequest objects.
 - Updating <settings-main> to display a "no results" page when no results
   are found.

BUG=630383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3cc76ff035eca6a47c8dfe31883a4b9978ee2432
Cr-Commit-Position: refs/heads/master@{#407856}
==========

[commit-bot: I haz the power, 2016-07-26 18:32:50]

Patchset 7 (id:??) landed as
https://crrev.com/3cc76ff035eca6a47c8dfe31883a4b9978ee2432
Cr-Commit-Position: refs/heads/master@{#407856}