Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2176743004: MD Settings: Implementing a "no results" page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/i18n/number_formatting.h" 10 #include "base/i18n/number_formatting.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 void AddCommonStrings(content::WebUIDataSource* html_source) { 63 void AddCommonStrings(content::WebUIDataSource* html_source) {
64 LocalizedString localized_strings[] = { 64 LocalizedString localized_strings[] = {
65 {"add", IDS_ADD}, 65 {"add", IDS_ADD},
66 {"cancel", IDS_CANCEL}, 66 {"cancel", IDS_CANCEL},
67 {"disable", IDS_DISABLE}, 67 {"disable", IDS_DISABLE},
68 {"learnMore", IDS_LEARN_MORE}, 68 {"learnMore", IDS_LEARN_MORE},
69 {"ok", IDS_OK}, 69 {"ok", IDS_OK},
70 {"save", IDS_SAVE}, 70 {"save", IDS_SAVE},
71 {"advancedPageTitle", IDS_SETTINGS_ADVANCED}, 71 {"advancedPageTitle", IDS_SETTINGS_ADVANCED},
72 {"basicPageTitle", IDS_SETTINGS_BASIC}, 72 {"basicPageTitle", IDS_SETTINGS_BASIC},
73 {"searchPrompt", IDS_SETTINGS_SEARCH_PROMPT},
74 // TODO(dpapad); IDS_DOWNLOAD_CLEAR_SEARCH and IDS_MD_HISTORY_CLEAR_SEARCH
75 // are identical, merge them to one and re-use here.
76 {"clearSearch", IDS_DOWNLOAD_CLEAR_SEARCH},
77 {"settings", IDS_SETTINGS_SETTINGS}, 73 {"settings", IDS_SETTINGS_SETTINGS},
78 {"restart", IDS_SETTINGS_RESTART}, 74 {"restart", IDS_SETTINGS_RESTART},
79 }; 75 };
80 AddLocalizedStringsBulk(html_source, localized_strings, 76 AddLocalizedStringsBulk(html_source, localized_strings,
81 arraysize(localized_strings)); 77 arraysize(localized_strings));
82 } 78 }
83 79
84 void AddA11yStrings(content::WebUIDataSource* html_source) { 80 void AddA11yStrings(content::WebUIDataSource* html_source) {
85 LocalizedString localized_strings[] = { 81 LocalizedString localized_strings[] = {
86 {"a11yPageTitle", IDS_SETTINGS_ACCESSIBILITY}, 82 {"a11yPageTitle", IDS_SETTINGS_ACCESSIBILITY},
(...skipping 896 matching lines...) Expand 10 before | Expand all | Expand 10 after
983 }; 979 };
984 AddLocalizedStringsBulk(html_source, localized_strings, 980 AddLocalizedStringsBulk(html_source, localized_strings,
985 arraysize(localized_strings)); 981 arraysize(localized_strings));
986 982
987 html_source->AddString("improveBrowsingExperience", 983 html_source->AddString("improveBrowsingExperience",
988 l10n_util::GetStringFUTF16( 984 l10n_util::GetStringFUTF16(
989 IDS_SETTINGS_IMPROVE_BROWSING_EXPERIENCE, 985 IDS_SETTINGS_IMPROVE_BROWSING_EXPERIENCE,
990 base::ASCIIToUTF16(chrome::kPrivacyLearnMoreURL))); 986 base::ASCIIToUTF16(chrome::kPrivacyLearnMoreURL)));
991 } 987 }
992 988
989 void AddSearchInSettingsStrings(content::WebUIDataSource* html_source) {
990 LocalizedString localized_strings[] = {
991 {"searchPrompt", IDS_SETTINGS_SEARCH_PROMPT},
992 {"searchNoResults", IDS_SETTINGS_SEARCH_NO_RESULTS},
993 // TODO(dpapad); IDS_DOWNLOAD_CLEAR_SEARCH and IDS_MD_HISTORY_CLEAR_SEARCH
994 // are identical, merge them to one and re-use here.
995 {"clearSearch", IDS_DOWNLOAD_CLEAR_SEARCH},
996 };
997 AddLocalizedStringsBulk(html_source, localized_strings,
998 arraysize(localized_strings));
999
1000 base::string16 help_text = l10n_util::GetStringFUTF16(
1001 IDS_SETTINGS_SEARCH_NO_RESULTS_HELP,
1002 base::ASCIIToUTF16(chrome::kSettingsSearchHelpURL));
1003 html_source->AddString("searchNoResultsHelp", help_text);
1004 }
1005
993 void AddSearchStrings(content::WebUIDataSource* html_source) { 1006 void AddSearchStrings(content::WebUIDataSource* html_source) {
994 LocalizedString localized_strings[] = { 1007 LocalizedString localized_strings[] = {
995 {"searchPageTitle", IDS_SETTINGS_SEARCH}, 1008 {"searchPageTitle", IDS_SETTINGS_SEARCH},
996 {"searchExplanation", IDS_SETTINGS_SEARCH_EXPLANATION}, 1009 {"searchExplanation", IDS_SETTINGS_SEARCH_EXPLANATION},
997 {"searchEnginesManage", IDS_SETTINGS_SEARCH_MANAGE_SEARCH_ENGINES}, 1010 {"searchEnginesManage", IDS_SETTINGS_SEARCH_MANAGE_SEARCH_ENGINES},
998 {"searchOkGoogleLabel", IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL}, 1011 {"searchOkGoogleLabel", IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL},
999 {"searchOkGoogleLearnMoreLink", 1012 {"searchOkGoogleLearnMoreLink",
1000 IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK}, 1013 IDS_SETTINGS_SEARCH_OK_GOOGLE_LEARN_MORE_LINK},
1001 {"searchOkGoogleDescriptionLabel", 1014 {"searchOkGoogleDescriptionLabel",
1002 IDS_SETTINGS_SEARCH_OK_GOOGLE_DESCRIPTION_LABEL}, 1015 IDS_SETTINGS_SEARCH_OK_GOOGLE_DESCRIPTION_LABEL},
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
1326 #if defined(OS_CHROMEOS) 1339 #if defined(OS_CHROMEOS)
1327 AddMultiProfilesStrings(html_source, profile); 1340 AddMultiProfilesStrings(html_source, profile);
1328 #endif 1341 #endif
1329 AddOnStartupStrings(html_source); 1342 AddOnStartupStrings(html_source);
1330 AddPasswordsAndFormsStrings(html_source); 1343 AddPasswordsAndFormsStrings(html_source);
1331 AddPeopleStrings(html_source); 1344 AddPeopleStrings(html_source);
1332 AddPrintingStrings(html_source); 1345 AddPrintingStrings(html_source);
1333 AddPrivacyStrings(html_source); 1346 AddPrivacyStrings(html_source);
1334 AddResetStrings(html_source); 1347 AddResetStrings(html_source);
1335 AddSearchEnginesStrings(html_source); 1348 AddSearchEnginesStrings(html_source);
1349 AddSearchInSettingsStrings(html_source);
1336 AddSearchStrings(html_source); 1350 AddSearchStrings(html_source);
1337 AddSiteSettingsStrings(html_source); 1351 AddSiteSettingsStrings(html_source);
1338 #if !defined(OS_CHROMEOS) 1352 #if !defined(OS_CHROMEOS)
1339 AddSystemStrings(html_source); 1353 AddSystemStrings(html_source);
1340 #endif 1354 #endif
1341 AddUsersStrings(html_source); 1355 AddUsersStrings(html_source);
1342 AddWebContentStrings(html_source); 1356 AddWebContentStrings(html_source);
1343 1357
1344 policy_indicator::AddLocalizedStrings(html_source); 1358 policy_indicator::AddLocalizedStrings(html_source);
1345 1359
1346 html_source->SetJsonPath(kLocalizedStringsFile); 1360 html_source->SetJsonPath(kLocalizedStringsFile);
1347 } 1361 }
1348 1362
1349 } // namespace settings 1363 } // namespace settings
OLDNEW
« no previous file with comments | « chrome/browser/resources/settings/settings_main/settings_main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698