Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2176743004: MD Settings: Implementing a "no results" page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index 2c9a01d9521eae5101abb091517600af201beb3c..cd8db770a7cd4648e05dfbf0fc18b9b515075060 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -36,8 +36,24 @@
iron-icon {
-webkit-margin-start: 16px;
}
+
+ #no-search-results {
+ align-items: center;
+ display: flex;
+ flex-direction: column;
+ margin-top: 80px;
+ }
+
+ #no-search-results div:first-child {
+ font-size: 120%;
+ margin-bottom: 10px;
+ }
</style>
<content select="paper-icon-button"></content>
+ <div id="no-search-results" hidden$="[[!showNoResultsFound_]]">
+ <div>$i18n{searchNoResults}</div>
+ <div>$i18nRaw{searchNoResultsHelp}</div>
+ </div>
<template is="dom-if" if="[[showPages_.basic]]">
<settings-basic-page prefs="{{prefs}}" current-route="{{currentRoute}}">
</settings-basic-page>
@@ -45,7 +61,7 @@
<template is="dom-if"
if="[[showAdvancedToggle_(showPages_.basic, inSubpage_)]]">
<div id="toggleSpacer"></div>
- <div id="toggleContainer">
+ <div id="toggleContainer" hidden$="[[showNoResultsFound_]]">
<div id="advancedToggle" on-tap="toggleAdvancedPage_">
<span>$i18n{advancedPageTitle}</span>
<iron-icon icon="[[arrowState_(showPages_.advanced)]]"></iron-icon>
« no previous file with comments | « chrome/browser/resources/settings/search_settings.js ('k') | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698