Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2176333002: Remove SkSurface::MakeRenderTargetDirect (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkSurface::MakeRenderTargetDirect split into: https://codereview.chromium.org/2182543003/ (Move prepareForExternalIO from GrRenderTarget to GrDrawContext) https://codereview.chromium.org/2187573002/ (Reduce usage of MakeRenderTargetDirect) https://codereview.chromium.org/2186073002/ (Rename GrContext's newDrawContext & drawContext to makeDrawContext) https://codereview.chromium.org/2178353005/ (Remove use of MakeRenderTargetDirect from view system) https://codereview.chromium.org/2198433003/ (Remove some ancillary users of SkSurface::MakeRenderTargetDirect) https://codereview.chromium.org/2208483004/ (Remove GrRenderTarget member variable from SkGpuDevice) https://codereview.chromium.org/2211473002/ (Move GrContext::makeDrawContext to new GrContextPriv object) TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2176333002 Committed: https://skia.googlesource.com/skia/+/15c42ca310e8b9785eab38b3dd36265948e85b0e

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : Clean up #

Patch Set 4 : update to ToT #

Patch Set 5 : update to ToT (again) #

Patch Set 6 : Clean up #

Patch Set 7 : More clean up #

Patch Set 8 : Fix up debugger #

Patch Set 9 : update to ToT #

Patch Set 10 : update to ToT #

Patch Set 11 : update to ToT #

Patch Set 12 : update to ToT #

Patch Set 13 : Clean up #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -87 lines) Patch
M include/core/SkSurface.h View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -21 lines 1 comment Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +6 lines, -31 lines 0 comments Download
M src/image/SkSurface.cpp View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 3 4 5 6 5 chunks +28 lines, -24 lines 0 comments Download

Messages

Total messages: 26 (20 generated)
robertphillips
https://codereview.chromium.org/2176333002/diff/240001/src/gpu/SkGpuDevice.h File src/gpu/SkGpuDevice.h (right): https://codereview.chromium.org/2176333002/diff/240001/src/gpu/SkGpuDevice.h#newcode43 src/gpu/SkGpuDevice.h:43: */ This is an unfortunate side-effect of how SkSurface_gpu ...
4 years, 4 months ago (2016-08-04 13:38:11 UTC) #11
egdaniel
lgtm
4 years, 4 months ago (2016-08-04 15:11:16 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176333002/240001
4 years, 4 months ago (2016-08-04 15:39:47 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/12163)
4 years, 4 months ago (2016-08-04 15:41:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2176333002/240001
4 years, 4 months ago (2016-08-04 15:43:48 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 15:45:05 UTC) #26
Message was sent while issue was closed. 
Committed patchset #13 (id:240001) as
https://skia.googlesource.com/skia/+/15c42ca310e8b9785eab38b3dd36265948e85b0e

Powered by Google App Engine
This is Rietveld 408576698