Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart

Issue 2176093002: Use Timer and not AnimationFrame during Observatory UI tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart b/runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart
index fe547857a42a4f11ec601d27ce1dc0d96b941e11..98b4f5abaa548b1639846b31636a687407e7b930 100644
--- a/runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart
@@ -3,17 +3,20 @@
// BSD-style license that can be found in the LICENSE file.
import 'dart:html';
import 'package:unittest/unittest.dart';
+import 'package:observatory/src/elements/helpers/rendering_queue.dart';
import 'package:observatory/src/elements/nav/bar.dart';
main() {
NavBarElement.tag.ensureRegistration();
+ final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
+ final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
test('instantiation', () {
final NavBarElement e = new NavBarElement();
expect(e, isNotNull, reason: 'element correctly created');
});
test('elements created', () async {
- final NavBarElement e = new NavBarElement();
+ final NavBarElement e = new NavBarElement(queue: queue);
document.body.append(e);
await e.onRendered.first;
expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');

Powered by Google App Engine
This is Rietveld 408576698