Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: runtime/observatory/tests/observatory_ui/curly_block/element_test.dart

Issue 2176093002: Use Timer and not AnimationFrame during Observatory UI tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/observatory_ui/curly_block/element_test.dart
diff --git a/runtime/observatory/tests/observatory_ui/curly_block/element_test.dart b/runtime/observatory/tests/observatory_ui/curly_block/element_test.dart
index fe1ca8f15f0d7c72a8441c5a9f38a5041621eab7..ca23a6c80c047c7c01c4b2874d7f1d1a42149810 100644
--- a/runtime/observatory/tests/observatory_ui/curly_block/element_test.dart
+++ b/runtime/observatory/tests/observatory_ui/curly_block/element_test.dart
@@ -4,10 +4,13 @@
import 'dart:html';
import 'package:unittest/unittest.dart';
import 'package:observatory/src/elements/curly_block.dart';
+import 'package:observatory/src/elements/helpers/rendering_queue.dart';
main() {
CurlyBlockElement.tag.ensureRegistration();
+ final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
+ final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
group('instantiation', () {
test('default', () {
final CurlyBlockElement e = new CurlyBlockElement();
@@ -69,7 +72,7 @@ main() {
});
});
test('elements created', () async {
- final CurlyBlockElement e = new CurlyBlockElement();
+ final CurlyBlockElement e = new CurlyBlockElement(queue: queue);
expect(e.shadowRoot, isNotNull, reason: 'shadowRoot is created');
document.body.append(e);
await e.onRendered.first;
@@ -82,12 +85,13 @@ main() {
group('content', () {
CurlyBlockElement e;
setUp(() async {
- e = new CurlyBlockElement();
+ e = new CurlyBlockElement(queue: queue);
document.body.append(e);
await e.onRendered.first;
});
- tearDown(() {
+ tearDown(() async {
e.remove();
+ await e.onRendered.first;
});
test('toggles visibility', () async {
expect(e.shadowRoot.querySelector('content'), isNull);
@@ -97,7 +101,6 @@ main() {
e.toggle();
await e.onRendered.first;
expect(e.shadowRoot.querySelector('content'), isNull);
- e.remove();
});
test('toggles visibility (manually)', () async {
expect(e.shadowRoot.querySelector('content'), isNull);
@@ -107,7 +110,6 @@ main() {
e.expanded = false;
await e.onRendered.first;
expect(e.shadowRoot.querySelector('content'), isNull);
- e.remove();
});
test('does not toggle if disabled', () async {
e.disabled = true;
@@ -128,7 +130,6 @@ main() {
await e.onRendered.first;
expect(e.expanded, isTrue);
expect(e.shadowRoot.querySelector('content'), isNotNull);
- e.remove();
});
test('toggles visibility (manually) if disabled', () async {
e.disabled = true;
@@ -140,13 +141,12 @@ main() {
e.expanded = false;
await e.onRendered.first;
expect(e.shadowRoot.querySelector('content'), isNull);
- e.remove();
});
});
group('event', () {
CurlyBlockElement e;
setUp(() async {
- e = new CurlyBlockElement();
+ e = new CurlyBlockElement(queue: queue);
document.body.append(e);
await e.onRendered.first;
});

Powered by Google App Engine
This is Rietveld 408576698