Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart

Issue 2176093002: Use Timer and not AnimationFrame during Observatory UI tests (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 import 'dart:html'; 4 import 'dart:html';
5 import 'package:unittest/unittest.dart'; 5 import 'package:unittest/unittest.dart';
6 import 'package:observatory/src/elements/helpers/rendering_queue.dart';
6 import 'package:observatory/src/elements/nav/bar.dart'; 7 import 'package:observatory/src/elements/nav/bar.dart';
7 8
8 main() { 9 main() {
9 NavBarElement.tag.ensureRegistration(); 10 NavBarElement.tag.ensureRegistration();
10 11
12 final TimedRenderingBarrier barrier = new TimedRenderingBarrier();
13 final RenderingQueue queue = new RenderingQueue.fromBarrier(barrier);
11 test('instantiation', () { 14 test('instantiation', () {
12 final NavBarElement e = new NavBarElement(); 15 final NavBarElement e = new NavBarElement();
13 expect(e, isNotNull, reason: 'element correctly created'); 16 expect(e, isNotNull, reason: 'element correctly created');
14 }); 17 });
15 test('elements created', () async { 18 test('elements created', () async {
16 final NavBarElement e = new NavBarElement(); 19 final NavBarElement e = new NavBarElement(queue: queue);
17 document.body.append(e); 20 document.body.append(e);
18 await e.onRendered.first; 21 await e.onRendered.first;
19 expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements'); 22 expect(e.shadowRoot.children.length, isNonZero, reason: 'has elements');
20 expect(e.shadowRoot.querySelector('content'), isNotNull, 23 expect(e.shadowRoot.querySelector('content'), isNotNull,
21 reason: 'has content elements'); 24 reason: 'has content elements');
22 e.remove(); 25 e.remove();
23 await e.onRendered.first; 26 await e.onRendered.first;
24 expect(e.shadowRoot.children.length, isZero, reason: 'is empty'); 27 expect(e.shadowRoot.children.length, isZero, reason: 'is empty');
25 }); 28 });
26 } 29 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698