Issue 2175863002: Allow going fullscreen during a screen orientation change handler.

Issue 2175863002: Allow going fullscreen during a screen orientation change handler. (Closed)

Created:
4 years, 5 months ago by mlamouri (slow - plz ping)

Modified:
4 years, 5 months ago

Reviewers:
foolip

CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, haraken, mlamouri+watch-screen-orientation_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, sof

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow going fullscreen during a screen orientation change handler. Currently, fullscreen request is only permitted when it is triggered by a user gesture. This is allowing allowing a screen orientation change to request fullscreen. This CL is taking over https://crrev.com/1818493002 from zqzhang@chromium.org BUG=594253 Committed: https://crrev.com/740ed214f4b05ea93bde8a38d889fdc1e5699946 Cr-Commit-Position: refs/heads/master@{#407531}

Patch Set 1 #

Total comments: 7

Patch Set 2 : review comments #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -9 lines)			Patch
A	third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/dom/Fullscreen.cpp	View		3 chunks	+11 lines, -9 lines	0 comments	Download
M	third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp	View		2 chunks	+3 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/platform/ScopedOrientationChangeIndicator.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/platform/ScopedOrientationChangeIndicator.cpp	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	third_party/WebKit/Source/platform/ScopedOrientationChangeIndicatorTest.cpp	View		1 chunk	+53 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/blink_platform.gypi	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (7 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

foolip

lgtm % nits, but if the change of order of checks wasn't a mistake then ...

4 years, 5 months ago (2016-07-23 00:33:54 UTC) #7

mlamouri (slow - plz ping)

I changed the checks order because I changed the order in the spec. It was ...

4 years, 5 months ago (2016-07-25 15:54:18 UTC) #8

foolip

On 2016/07/25 15:54:18, Mounir Lamouri wrote: > I changed the checks order because I changed ...

4 years, 5 months ago (2016-07-25 17:15:45 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175863002/20001

4 years, 5 months ago (2016-07-25 17:23:12 UTC) #11

commit-bot: I haz the power

4 years, 5 months ago (2016-07-25 18:55:45 UTC) #14

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/740ed214f4b05ea93bde8a38d889fdc1e5699946
Cr-Commit-Position: refs/heads/master@{#407531}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages