third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp - Issue 2175863002: Allow going fullscreen during a screen orientation change handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 2175863002: Allow going fullscreen during a screen orientation change handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/Fullscreen.cpp ('k') | third_party/WebKit/Source/platform/ScopedOrientationChangeIndicator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

index a1a1186ce118d50d4a20e9979df15ce5073eba52..d87d1887abc9028651b6f1295009848f8ba68a2d 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

@@ -13,6 +13,7 @@

#include "modules/screen_orientation/ScreenOrientation.h"

#include "modules/screen_orientation/ScreenOrientationDispatcher.h"

#include "platform/LayoutTestSupport.h"

+#include "platform/ScopedOrientationChangeIndicator.h"

#include "public/platform/WebScreenInfo.h"

#include "public/platform/modules/screen_orientation/WebScreenOrientationClient.h"

@@ -174,6 +175,8 @@ void ScreenOrientationController::dispatchEventTimerFired(Timer<ScreenOrientatio

{

if (!m_orientation)

return;

+ ScopedOrientationChangeIndicator orientationChangeIndicator;

m_orientation->dispatchEvent(Event::create(EventTypeNames::change));

}