third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html - Issue 2175863002: Allow going fullscreen during a screen orientation change handler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fullscreen/full-screen-orientation-change.html

Issue 2175863002: Allow going fullscreen during a screen orientation change handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <title>Test that full screen requests are allowed when inside an orientation cha nge handler.</title>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <span></span>

	7 <script>

	8

	9 var element = document.querySelector('span');

	10

	11 async_test(function(t) {

	12 window.screen.orientation.onchange = function() {
	foolip 2016/07/23 00:33:54 wrap in t.step_func wrap in t.step_func mlamouri (slow - plz ping) 2016/07/25 15:54:18 Done. Show quoted text On 2016/07/23 at 00:33:54, foolip wrote: > wrap in t.step_func Done.
	13 element.webkitRequestFullScreen();

	14 };

	15

	16 document.onwebkitfullscreenerror = t.step_func(function(e) {
	foolip 2016/07/23 00:33:54 Argument e is unused, assertunreached is missing a Argument e is unused, assertunreached is missing a _ and t.done() wouldn't do anything, but just t.unreached_func("fullscreen is not accepted when orientation is changed") would work here :) mlamouri (slow - plz ping) 2016/07/25 15:54:18 Done. Show quoted text On 2016/07/23 at 00:33:54, foolip wrote: > Argument e is unused, assertunreached is missing a _ and t.done() wouldn't do anything, but just t.unreached_func("fullscreen is not accepted when orientation is changed") would work here :) Done.
	17 assertunreached("fullscreen is not accepted when orientation is changed");

	18 t.done();

	19 });

	20

	21 document.onwebkitfullscreenchange = t.step_func_done();

	22 window.testRunner.setMockScreenOrientation('landscape-primary');

	23 });

	24

	25 </script>

	26 </body>
	foolip 2016/07/23 00:33:54 There's no explicit <body>, but in any case you ca There's no explicit <body>, but in any case you can drop the opening <html> and the closing bits here. mlamouri (slow - plz ping) 2016/07/25 15:54:18 Done. Sorry for the messy test. I should have tak Show quoted text On 2016/07/23 at 00:33:54, foolip wrote: > There's no explicit <body>, but in any case you can drop the opening <html> and the closing bits here. Done. Sorry for the messy test. I should have taken more time converting Zhiqiang's test to what I wanted to do. Thanks for the thorough review :)
	27 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('j') | third_party/WebKit/Source/core/dom/Fullscreen.cpp » ('J')