make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

content/browser/renderer_host/pepper/pepper_tcp_socket.cc

Index: content/browser/renderer_host/pepper/pepper_tcp_socket.cc
diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket.cc
index c5b752aa7f5f058f247d2a3098aba6a3409a3c3e..4e386823605167c512aff577c3502e7de1fd685a 100644
--- a/content/browser/renderer_host/pepper/pepper_tcp_socket.cc
+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket.cc
@@ -260,13 +260,13 @@ void PepperTCPSocket::SetOption(PP_TCPSocket_Option name,
           SendSetOptionACK(PP_ERROR_BADARGUMENT);
           return;
         }
-        result = tcp_socket->SetSendBufferSize(integer_value);
+        result = tcp_socket->SetSendBufferSize(integer_value) == net::OK;
       } else {
         if (integer_value > ppapi::TCPSocketShared::kMaxReceiveBufferSize) {
           SendSetOptionACK(PP_ERROR_BADARGUMENT);
           return;
         }
-        result = tcp_socket->SetReceiveBufferSize(integer_value);
+        result = tcp_socket->SetReceiveBufferSize(integer_value) == net::OK;
       }
       SendSetOptionACK(result ? PP_OK : PP_ERROR_FAILED);

[wtc, 2014/03/29 13:30:12]

Nit: You can ignore this suggestion.

  int result = net::ERR_UNEXPECTED;
  if (...) {
    ...
    result = tcp_socket->SetSendBufferSize(integer_value);
  } else {
    result = tcp_socket->SetReceiveBufferSize(integer_value);
  }
  SendSetOptionACK(result == net::OK ? PP_OK : PP_ERROR_FAILED);

Note that this method now has an opportunity to do error code mapping (from
net::ERR_xxx to PP_xxx). Maybe you can add a TODO comment.

[jar (doing other things), 2014/04/01 23:50:39]

I made the change, and added a TODO... but assigned to you.  If you know a
better target, I'll use him/her. thx!

       return;