content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc - Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: process error code in quic_stream_factory Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/pepper/pepper_tcp_socket.cc ('K') | « content/browser/renderer_host/pepper/pepper_tcp_socket.cc ('k') | content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc » ('j') | content/browser/renderer_host/pepper/pepper_udp_socket_message_filter.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

diff --git a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

index 97276160385a1483cb3e5b49d67e0bd84eef5e08..f5189b9d897e47a87d252a1e6816c5fa363633a6 100644

--- a/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

+++ b/content/browser/renderer_host/pepper/pepper_tcp_socket_message_filter.cc

@@ -459,11 +459,11 @@ int32_t PepperTCPSocketMessageFilter::OnMsgSetOption(

if (name == PP_TCPSOCKET_OPTION_SEND_BUFFER_SIZE) {

if (integer_value > TCPSocketResourceBase::kMaxSendBufferSize)

return PP_ERROR_BADARGUMENT;

- result = socket_->SetSendBufferSize(integer_value);

+ result = socket_->SetSendBufferSize(integer_value) == net::OK;

} else {

if (integer_value > TCPSocketResourceBase::kMaxReceiveBufferSize)

return PP_ERROR_BADARGUMENT;

- result = socket_->SetReceiveBufferSize(integer_value);

+ result = socket_->SetReceiveBufferSize(integer_value) == net::OK;

}

return result ? PP_OK : PP_ERROR_FAILED;

wtc 2014/03/29 13:30:12 Nit: see my suggestion in the previous file.

jar (doing other things) 2014/04/01 23:50:39 Done as in previous file... with TODO(wtc).

}