chrome/browser/devtools/adb/android_usb_socket.cc - Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/adb/android_usb_socket.cc

Issue 217573002: make SetReceiveBufferSize and SetSendBufferSize return net error codes (instead of bools) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: process error code in quic_stream_factory Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/adb/android_usb_socket.h ('k') | content/browser/renderer_host/p2p/socket_host_tcp.cc » ('j') | content/browser/renderer_host/pepper/pepper_tcp_socket.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/adb/android_usb_socket.cc

diff --git a/chrome/browser/devtools/adb/android_usb_socket.cc b/chrome/browser/devtools/adb/android_usb_socket.cc

index ee9c9df5674dda237ce4fc83fc653d7859715c20..9b303be6b303bc353a255e6abe1b695fb695df50 100644

--- a/chrome/browser/devtools/adb/android_usb_socket.cc

+++ b/chrome/browser/devtools/adb/android_usb_socket.cc

@@ -137,14 +137,14 @@ int AndroidUsbSocket::Write(net::IOBuffer* buffer,

return net::ERR_IO_PENDING;

}

-bool AndroidUsbSocket::SetReceiveBufferSize(int32 size) {

+int AndroidUsbSocket::SetReceiveBufferSize(int32 size) {

NOTIMPLEMENTED();

- return false;

+ return net::ERR_NOT_IMPLEMENTED;

}

-bool AndroidUsbSocket::SetSendBufferSize(int32 size) {

+int AndroidUsbSocket::SetSendBufferSize(int32 size) {

NOTIMPLEMENTED();

- return false;

+ return net::ERR_NOT_IMPLEMENTED;

}

int AndroidUsbSocket::Connect(const net::CompletionCallback& callback) {