Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2175573004: Revert of Retract PipelineBuilder some more (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Retract PipelineBuilder some more (patchset #9 id:160001 of https://codereview.chromium.org/2092893003/ ) Reason for revert: skbug.com/5559 Original issue's description: > Retract PipelineBuilder some more > > The main part of this CL is widening SkDrawContext::drawBatch's API to accept the userStencilSettings & drawFace > > There is some ancillary spookiness related to expanding the should_apply_coverage_aa & mustUseHWAA methods to encompass mixedSamples > > Calved off: > https://codereview.chromium.org/2165283002/ (Remove DrawFace enum from GrPipelineBuilder) > https://codereview.chromium.org/2167183002/ (Minor change to Ganesh path renderers) > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2092893003 > > Committed: https://skia.googlesource.com/skia/+/2895eeb11a9f0d9c0018d49dd4bc45f6c6fc062c TBR=robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/bb24383abb724c516e472af4eec68f2c3f17a6d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -63 lines) Patch
M include/gpu/GrDrawContext.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 4 chunks +11 lines, -16 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 2 chunks +8 lines, -6 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 3 chunks +6 lines, -1 line 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 2 chunks +6 lines, -1 line 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 3 chunks +5 lines, -8 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 2 chunks +13 lines, -6 lines 0 comments Download
M src/gpu/batches/GrMSAAPathRenderer.cpp View 3 chunks +11 lines, -6 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 3 chunks +17 lines, -6 lines 0 comments Download
M src/gpu/batches/GrTessellatingPathRenderer.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M src/gpu/text/GrAtlasTextBlob.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bsalomon
Created Revert of Retract PipelineBuilder some more
4 years, 5 months ago (2016-07-22 14:10:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2175573004/1
4 years, 5 months ago (2016-07-22 14:10:13 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 14:10:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bb24383abb724c516e472af4eec68f2c3f17a6d0

Powered by Google App Engine
This is Rietveld 408576698