Remove the unnecessary blockquote after indenting an empty blockquote

Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows:

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html

Committed: https://crrev.com/b844ddd6c6b82784257c183e50244eff895bce09
Cr-Commit-Position: refs/heads/master@{#407091}

[joone, 2016-07-21 20:57:45]

The CQ bit was checked by joone.hur@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 20:58:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2016-07-21 22:19:07]

joone.hur@intel.com changed reviewers:
+ yosin@chromium.org

[joone, 2016-07-21 22:19:08]

Hi yosin@ could you take a look at this CL?

[joone, 2016-07-21 22:22:51]

Description was changed from

==========
Remove the unnecessary blockquote after indenting an empty blockquote

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

to

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable><blockquote><blockquote style="margin: 0 0 0 40px; border:
none; padding:
0px;"><blockquote>|<br></blockquote></blockquote></blockquote></div>

There is an unnecessary blockquote so the result should be as follows: 

<div contenteditable><blockquote style="margin: 0 0 0 40px; border: none;
padding: 0px;"><blockquote>|<br></blockquote></blockquote></div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

[commit-bot: I haz the power, 2016-07-21 22:23:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 22:23:41]

Dry run: This issue passed the CQ dry run.

[joone, 2016-07-21 22:24:41]

Description was changed from

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable><blockquote><blockquote style="margin: 0 0 0 40px; border:
none; padding:
0px;"><blockquote>|<br></blockquote></blockquote></blockquote></div>

There is an unnecessary blockquote so the result should be as follows: 

<div contenteditable><blockquote style="margin: 0 0 0 40px; border: none;
padding: 0px;"><blockquote>|<br></blockquote></blockquote></div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

to

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows: 

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

[yosin_UTC9, 2016-07-22 01:21:55]

lgtm w/ small nits in test file.

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html
(right):

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html:1:
<!doctype html>
Could you put this test file in "LayoutTests/editing/execCommand/indent" with
using underscore to follow Chromium file name convention?

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html:10:
'indent true',
nit: I think we don't need to have |true|, since "indent" command doesn't take
string parameter.

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html:16:
'indent true',
nit: I think we don't need to have |true|, since "indent" command doesn't take
string parameter.

[joone, 2016-07-22 03:29:54]

Thanks for the review!

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html
(right):

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html:1:
<!doctype html>
On 2016/07/22 01:21:55, Yosi_UTC9 wrote:
> Could you put this test file in "LayoutTests/editing/execCommand/indent" with
> using underscore to follow Chromium file name convention?

Done.

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html:10:
'indent true',
On 2016/07/22 01:21:55, Yosi_UTC9 wrote:
> nit: I think we don't need to have |true|, since "indent" command doesn't take
> string parameter.

Done.

https://codereview.chromium.org/2175433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html:16:
'indent true',
On 2016/07/22 01:21:55, Yosi_UTC9 wrote:
> nit: I think we don't need to have |true|, since "indent" command doesn't take
> string parameter.

Done.

[joone, 2016-07-22 03:30:59]

The CQ bit was checked by joone.hur@intel.com

[joone, 2016-07-22 03:31:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2175433002/#ps20001
(title: "move the test case to indent folder")

[commit-bot: I haz the power, 2016-07-22 03:32:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 04:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 04:50:37]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[joone, 2016-07-22 04:52:25]

The CQ bit was checked by joone.hur@intel.com

[commit-bot: I haz the power, 2016-07-22 04:52:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joone, 2016-07-22 05:52:07]

The CQ bit was checked by joone.hur@intel.com

[joone, 2016-07-22 05:52:08]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2175433002/#ps40001
(title: "fix test fail")

[commit-bot: I haz the power, 2016-07-22 05:52:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 07:14:59]

Description was changed from

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows: 

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

to

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows: 

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

[commit-bot: I haz the power, 2016-07-22 07:15:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 07:16:58]

Description was changed from

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows: 

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html
==========

to

==========
Remove the unnecessary blockquote after indenting an empty blockquote

Here is a DOM state when we only add a blockquote.
<div contenteditable><blockquote>|<br></blockquote></div>

After indenting the blockquote, the change is as follows:
<div contenteditable>
  <blockquote>
    <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
      <blockquote>|<br></blockquote>
    </blockquote>
  </blockquote>
</div>

There is an unnecessary blockquote so the result should be as follows:

<div contenteditable>
  <blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;">
    <blockquote>|<br></blockquote>
  </blockquote>
</div>

This CL removes the additional blockquote.

BUG=625802
TEST=editing/execCommand/indent-empty-quote.html

Committed: https://crrev.com/b844ddd6c6b82784257c183e50244eff895bce09
Cr-Commit-Position: refs/heads/master@{#407091}
==========

[commit-bot: I haz the power, 2016-07-22 07:16:59]

Patchset 3 (id:??) landed as
https://crrev.com/b844ddd6c6b82784257c183e50244eff895bce09
Cr-Commit-Position: refs/heads/master@{#407091}