third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html - Issue 2175433002: Remove the unnecessary blockquote after indenting an empty blockquote

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/indent-empty-quote.html

Issue 2175433002: Remove the unnecessary blockquote after indenting an empty blockquote (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!doctype html>
	yosin_UTC9 2016/07/22 01:21:55 Could you put this test file in "LayoutTests/editi Could you put this test file in "LayoutTests/editing/execCommand/indent" with using underscore to follow Chromium file name convention? joone 2016/07/22 03:29:54 Done. Show quoted text On 2016/07/22 01:21:55, Yosi_UTC9 wrote: > Could you put this test file in "LayoutTests/editing/execCommand/indent" with > using underscore to follow Chromium file name convention? Done.
	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script src="../assert_selection.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 test(() => {

	8 assert_selection(

	9 '<div contenteditable><blockquote>\|<br></blockquote></div>',

	10 'indent true',
	yosin_UTC9 2016/07/22 01:21:55 nit: I think we don't need to have \|true\|, since " nit: I think we don't need to have \|true\|, since "indent" command doesn't take string parameter. joone 2016/07/22 03:29:54 Done. Show quoted text On 2016/07/22 01:21:55, Yosi_UTC9 wrote: > nit: I think we don't need to have \|true\|, since "indent" command doesn't take > string parameter. Done.
	11 '<div contenteditable><blockquote style="margin: 0 0 0 40px; border: none; p adding: 0px;"><blockquote>\|<br></blockquote></blockquote></div>');

	12 }, 'indent empty <blockquote>');

	13 test(() => {

	14 assert_selection(

	15 '<div contenteditable><blockquote>1\|</blockquote></div>',

	16 'indent true',
	yosin_UTC9 2016/07/22 01:21:55 nit: I think we don't need to have \|true\|, since " nit: I think we don't need to have \|true\|, since "indent" command doesn't take string parameter. joone 2016/07/22 03:29:54 Done. Show quoted text On 2016/07/22 01:21:55, Yosi_UTC9 wrote: > nit: I think we don't need to have \|true\|, since "indent" command doesn't take > string parameter. Done.
	17 '<div contenteditable><blockquote style="margin: 0 0 0 40px; border: none; p adding: 0px;"><blockquote>1\|</blockquote></blockquote></div>');

	18 }, 'indent <blockquote> with text');

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »