Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java

Issue 2175353003: [Remoting Android] Define feedback animation size in dp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set up radius inside AbstractDesktopView Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java b/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
index 4a1ff236aee80de42dd5112a63e3c1946ce0c35d..bd2abdfd10ec325942178a2cf4e06a351ef82f7f 100644
--- a/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
+++ b/remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java
@@ -36,28 +36,12 @@ public final class FeedbackAnimator
/** Begins a new animation sequence at position (|pos|). */
public static void startAnimation(DesktopView view,
Point pos,
- DesktopView.InputFeedbackType feedbackType) {
- if (feedbackType == DesktopView.InputFeedbackType.NONE) {
+ float feedbackRadius) {
+ if (feedbackRadius <= 0) {
joedow 2016/07/26 03:03:24 it might be clearer to compare with 0.0f here.
Yuwei 2016/07/26 18:47:26 Done.
return;
}
- view.onPaint().addSelfRemovable(new FeedbackAnimator(
- getInputFeedbackSizeInPixels(feedbackType), pos));
- }
-
- private static float getInputFeedbackSizeInPixels(DesktopView.InputFeedbackType feedbackType) {
- switch (feedbackType) {
- case SMALL_ANIMATION:
- return 40.0f;
-
- case LARGE_ANIMATION:
- return 160.0f;
-
- default:
- // Unreachable, but required by Google Java style and findbugs.
- assert false : "Unreached";
- return 0.0f;
- }
+ view.onPaint().addSelfRemovable(new FeedbackAnimator(feedbackRadius, pos));
}
@Override

Powered by Google App Engine
This is Rietveld 408576698