Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

Issue 2175353003: [Remoting Android] Define feedback animation size in dp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set up radius inside AbstractDesktopView Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/DesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
index d99eb127329e0e5f1011c85c9540bef1c1b2c2e2..1a705955cfc2fd48d4d8ae2123f11e1ac867cd91 100644
--- a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
@@ -224,11 +224,9 @@ public class DesktopView extends AbstractDesktopView implements SurfaceHolder.Ca
}
@Override
- public void showInputFeedback(InputFeedbackType feedbackToShow, Point pos) {
- if (feedbackToShow != InputFeedbackType.NONE) {
Yuwei 2016/07/25 23:43:12 Removed this check since NONE is not been used any
joedow 2016/07/26 03:03:24 It is set in a few places. The check was useful a
Yuwei 2016/07/26 18:47:26 You are right. Looks like it is set in several pla
- FeedbackAnimator.startAnimation(this, pos, feedbackToShow);
- requestRepaint();
- }
+ public void showInputFeedback(float feedbackRadius, Point pos) {
+ FeedbackAnimator.startAnimation(this, pos, feedbackRadius);
+ requestRepaint();
}
@Override

Powered by Google App Engine
This is Rietveld 408576698