[Remoting Android] Define feedback animation size in dp

remoting/android/java/src/org/chromium/chromoting/FeedbackAnimator.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.graphics.Color;
 import android.graphics.Paint;
 import android.graphics.Point;
 import android.graphics.RadialGradient;
@@ skipping 18 matching lines @@
 
     private FeedbackAnimator(float feedbackSizeInPixels, Point pos) {
         mStartTimeInMs = SystemClock.uptimeMillis();
         mFeedbackSizeInPixels = feedbackSizeInPixels;
         mPos = pos;
     }
 
     /** Begins a new animation sequence at position (|pos|). */
     public static void startAnimation(DesktopView view,
                                       Point pos,
-                                      DesktopView.InputFeedbackType feedbackType) {
-        if (feedbackType == DesktopView.InputFeedbackType.NONE) {
+                                      float feedbackRadius) {
+        if (feedbackRadius <= 0) {

[joedow, 2016/07/26 03:03:24]

it might be clearer to compare with 0.0f here. 

[Yuwei, 2016/07/26 18:47:26]

Done.

             return;
         }
 
-        view.onPaint().addSelfRemovable(new FeedbackAnimator(
-                getInputFeedbackSizeInPixels(feedbackType), pos));
-    }
-
-    private static float getInputFeedbackSizeInPixels(DesktopView.InputFeedbackType feedbackType) {
-        switch (feedbackType) {
-            case SMALL_ANIMATION:
-                return 40.0f;
-
-            case LARGE_ANIMATION:
-                return 160.0f;
-
-            default:
-                // Unreachable, but required by Google Java style and findbugs.
-                assert false : "Unreached";
-                return 0.0f;
-        }
+        view.onPaint().addSelfRemovable(new FeedbackAnimator(feedbackRadius, pos));
     }
 
     @Override
     public Boolean run(PaintEventParameter parameter) {
         float elapsedTimeInMs = SystemClock.uptimeMillis() - mStartTimeInMs;
         if (elapsedTimeInMs < 1) {
             return true;
         }
 
         // |progress| is 0 at the beginning, 1 at the end.
@@ skipping 13 matching lines @@
         int transparentBlack = Color.argb(0, 0, 0, 0);
         int white = Color.argb(alpha, 0xff, 0xff, 0xff);
         int black = Color.argb(alpha, 0, 0, 0);
         mPaint.setShader(new RadialGradient(mPos.x, mPos.y, radius,
                 new int[] {transparentBlack, white, black, transparentBlack},
                 new float[] {0.0f, 0.8f, 0.9f, 1.0f}, Shader.TileMode.CLAMP));
         parameter.canvas.drawCircle(mPos.x, mPos.y, radius, mPaint);
         return true;
     }
 }