Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: cc/trees/layer_tree_host_unittest_scroll.cc

Issue 2174653002: cc: Break up with FakeLayerTreeHostClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fakeoutputsurface
Patch Set: lthclient-tests: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/stub_layer_tree_host_single_thread_client.cc ('k') | cc/trees/tree_synchronizer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest_scroll.cc
diff --git a/cc/trees/layer_tree_host_unittest_scroll.cc b/cc/trees/layer_tree_host_unittest_scroll.cc
index 9fc17f67c316cccc7e05d19f8afba390d3f011d7..03c34bbced8bdcba39a1324140bda16d9d9dc267 100644
--- a/cc/trees/layer_tree_host_unittest_scroll.cc
+++ b/cc/trees/layer_tree_host_unittest_scroll.cc
@@ -1351,20 +1351,17 @@ void BindInputHandlerOnCompositorThread(
TEST(LayerTreeHostFlingTest, DidStopFlingingThread) {
base::Thread impl_thread("cc");
ASSERT_TRUE(impl_thread.Start());
+ ASSERT_TRUE(impl_thread.task_runner());
bool received_stop_flinging = false;
LayerTreeSettings settings;
- ThreadCheckingInputHandlerClient input_handler_client(
- impl_thread.task_runner().get(), &received_stop_flinging);
- FakeLayerTreeHostClient client;
-
- ASSERT_TRUE(impl_thread.task_runner());
+ StubLayerTreeHostClient layer_tree_host_client;
TestSharedBitmapManager shared_bitmap_manager;
TestTaskGraphRunner task_graph_runner;
LayerTreeHost::InitParams params;
- params.client = &client;
+ params.client = &layer_tree_host_client;
params.shared_bitmap_manager = &shared_bitmap_manager;
params.task_graph_runner = &task_graph_runner;
params.settings = &settings;
@@ -1373,6 +1370,8 @@ TEST(LayerTreeHostFlingTest, DidStopFlingingThread) {
std::unique_ptr<LayerTreeHost> layer_tree_host =
LayerTreeHost::CreateThreaded(impl_thread.task_runner(), &params);
+ ThreadCheckingInputHandlerClient input_handler_client(
+ impl_thread.task_runner().get(), &received_stop_flinging);
impl_thread.task_runner()->PostTask(
FROM_HERE, base::Bind(&BindInputHandlerOnCompositorThread,
layer_tree_host->GetInputHandler(),
« no previous file with comments | « cc/test/stub_layer_tree_host_single_thread_client.cc ('k') | cc/trees/tree_synchronizer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698