Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2174273002: [telemetry] Don't use time.sleep in text entry tests (Closed)

Created:
4 years, 4 months ago by petrcermak
Modified:
4 years, 4 months ago
Reviewers:
nednguyen, achuithb
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[telemetry] Don't use time.sleep in text entry tests This patch modifies KeyPressActionTest.testTextEntry and ActionRunnerTest.testEnterText to use `WaitForJavaScript(Condition|Expression)` instead of `time.sleep`. BUG=chromium:630017 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2befef4332bccf830c80b0c1806ad44409bb1b9c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M telemetry/telemetry/internal/actions/action_runner_unittest.py View 1 chunk +5 lines, -7 lines 1 comment Download
M telemetry/telemetry/internal/actions/key_event_unittest.py View 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
petrcermak
PTAL. Thanks, Petr
4 years, 4 months ago (2016-07-25 11:38:58 UTC) #3
nednguyen
lgtm
4 years, 4 months ago (2016-07-25 11:43:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174273002/1
4 years, 4 months ago (2016-07-25 11:43:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/2befef4332bccf830c80b0c1806ad44409bb1b9c
4 years, 4 months ago (2016-07-25 12:08:40 UTC) #8
achuithb
4 years, 4 months ago (2016-07-25 18:44:34 UTC) #9
Message was sent while issue was closed.
lgtm. Thanks for taking care of the comments in the other CL

https://codereview.chromium.org/2174273002/diff/1/telemetry/telemetry/interna...
File telemetry/telemetry/internal/actions/action_runner_unittest.py (right):

https://codereview.chromium.org/2174273002/diff/1/telemetry/telemetry/interna...
telemetry/telemetry/internal/actions/action_runner_unittest.py:283: timeout=1)
You could consider increasing the timeout to a few seconds since there's no real
cost to this.

Powered by Google App Engine
This is Rietveld 408576698