[telemetry] Don't use time.sleep in text entry tests

telemetry/telemetry/internal/actions/action_runner_unittest.py

Index: telemetry/telemetry/internal/actions/action_runner_unittest.py
diff --git a/telemetry/telemetry/internal/actions/action_runner_unittest.py b/telemetry/telemetry/internal/actions/action_runner_unittest.py
index 3b190c8cf8547f2aa4863d625110dc601f572eaf..a6d75651d057da1ed851de30a81738b416b4605b 100644
--- a/telemetry/telemetry/internal/actions/action_runner_unittest.py
+++ b/telemetry/telemetry/internal/actions/action_runner_unittest.py
@@ -276,13 +276,11 @@ class ActionRunnerTest(tab_test_case.TabTestCase):
     action_runner.PressKey('Backspace', repeat_count=3)  # This is |ing.
     action_runner.EnterText('interest')  # This is interest|ing.
 
-    # Wait for a second to make sure that all keystrokes have been handled by
-    # the browser (crbug.com/630017).
-    action_runner.Wait(1)
-
-    self.assertEqual('This is interesting',
-                     self._tab.EvaluateJavaScript(
-                         'document.querySelector("textarea").value'))
+    # Check that the contents of the textarea is correct. It might take a second
+    # until all keystrokes have been handled by the browser (crbug.com/630017).
+    self._tab.WaitForJavaScriptExpression(
+        'document.querySelector("textarea").value === "This is interesting"',
+        timeout=1)

[achuithb, 2016/07/25 18:44:34]

You could consider increasing the timeout to a few seconds since there's no real
cost to this.

 
 
 class InteractionTest(unittest.TestCase):