Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: telemetry/telemetry/internal/actions/key_event_unittest.py

Issue 2174273002: [telemetry] Don't use time.sleep in text entry tests (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/actions/key_event_unittest.py
diff --git a/telemetry/telemetry/internal/actions/key_event_unittest.py b/telemetry/telemetry/internal/actions/key_event_unittest.py
index 45d4e1bae29eadd72a2e958c964868d799ce9368..d842dd76a90435c0a44c3fa7a622f9039f6f7466 100644
--- a/telemetry/telemetry/internal/actions/key_event_unittest.py
+++ b/telemetry/telemetry/internal/actions/key_event_unittest.py
@@ -75,14 +75,11 @@ class KeyPressActionTest(tab_test_case.TabTestCase):
self._PressKey('Backspace')
self._PressKey('Return')
- # Wait for a second to make sure that all keystrokes have been handled by
- # the browser (crbug.com/630017).
- time.sleep(1)
-
- # Check that the contents of the textarea is correct.
- self.assertEquals('Hello,\nWorld!',
- self._tab.EvaluateJavaScript(
- 'document.querySelector("textarea").value'))
+ # Check that the contents of the textarea is correct. It might take a second
+ # until all keystrokes have been handled by the browser (crbug.com/630017).
+ self._tab.WaitForJavaScriptExpression(
+ 'document.querySelector("textarea").value === "Hello,\\nWorld!"',
+ timeout=1)
def testPressUnknownKey(self):
with self.assertRaises(ValueError):

Powered by Google App Engine
This is Rietveld 408576698