Blimp settings UI integration for Chrome, everything still lives in Blimp.

Blimp settings UI integration for Chrome, everything still lives in Blimp.

Previously Blimp code is in blimp/app, this CL port settings UI code to core, and reuse Java resources files in blimp/app.(We can setup new one in core or somewhere if needed)

In this way, all UI resources, and code live in Blimp so we don't leak things to Chrome at the moment.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451
Committed: https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151
Cr-Commit-Position: refs/heads/master@{#408281}

[xingliu, 2016-07-22 00:07:23]

Description was changed from

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.

Previously Blimp code is in blimp/app, this CL port settings UI to core.
Basically all resources, code lives in Blimp so we don't leak things to Chrome.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=
==========

to

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.

Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 

In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=
==========

[xingliu, 2016-07-22 00:07:40]

Description was changed from

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.

Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 

In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=
==========

to

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.


Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 


In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.


For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=
==========

[xingliu, 2016-07-22 00:29:32]

Description was changed from

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.


Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 


In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.


For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=
==========

to

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.


Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 


In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.


For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451
==========

[xingliu, 2016-07-22 00:30:49]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[xingliu, 2016-07-22 00:30:50]

Put all pref UI code to blimp core, so don't leak things to Chrome for now.

[xingliu, 2016-07-22 00:31:20]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 00:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 00:39:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:39:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xingliu, 2016-07-22 01:23:20]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 01:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 02:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 02:17:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2016-07-22 16:06:14]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 16:06:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[David Trainor- moved to gerrit, 2016-07-22 16:51:43]

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
File blimp/client/app/android/java/res/values/arrays.xml (right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
blimp/client/app/android/java/res/values/arrays.xml:7: <string-array
name="assigner_envs">
Should we remove these?

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
blimp/client/app/android/java/res/values/arrays.xml:18: <!-- Blimp preferences
for Chrome, all array names should prefix with blimp -->
Add a . after blimp.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
blimp/client/app/android/java/res/values/arrays.xml:19: <!-- These need to port
to Chrome in the future. -->
Could you explain why?  If we do need to, file a bug and reference it here.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java:48:
public  void attachBlimpPreferences(PreferenceFragment fragment,
Remove extra space

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:20:
// import org.chromium.chrome.browser.ApplicationLifetime;
?

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:28:
private static final String PREF_ASSIGNER_URL = "blimp_assigner_url";
Public as well.  And javadocs for both :).  Or helper methods?

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:70:
// An alternative is to use {@link ChromeSwitchPreference}.
Can you add a TODO and a bug for when this is moved out of blimp/?

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:131:
private static void restartBrowser(Context context) {
Do we need the context?

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:133:
sSettingsCallback.onRestartBrowserRequested();
Just to confirm, there's no way to avoid restarting right?  If so, we should
undo the preference changes that were made or something.

https://codereview.chromium.org/2173563003/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpPreferencesTest.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpPreferencesTest.java:22:
public class BlimpPreferencesTest extends ChromeTabbedActivityTestBase {
Can we just test that the fragment loads and that we get valid callbacks and
shared pref values?  We could put this test inside blimp/ and avoid the
integration issues.

https://codereview.chromium.org/2173563003/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpPreferencesTest.java:23:
public static final String PREF_BLIMP_SWITCH = "blimp_switch";
private?

[commit-bot: I haz the power, 2016-07-22 17:23:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:23:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xingliu, 2016-07-23 22:58:03]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 22:58:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-07-23 23:12:49]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 23:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-07-23 23:50:36]

Thanks for the code review.

This patch moved test code to blimp, and fixed issues based on review.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
File blimp/client/app/android/java/res/values/arrays.xml (right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
blimp/client/app/android/java/res/values/arrays.xml:7: <string-array
name="assigner_envs">
On 2016/07/22 16:51:42, David Trainor wrote:
> Should we remove these?

Done. And adjust v0.5 code to use the new array name.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
blimp/client/app/android/java/res/values/arrays.xml:18: <!-- Blimp preferences
for Chrome, all array names should prefix with blimp -->
On 2016/07/22 16:51:42, David Trainor wrote:
> Add a . after blimp.

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/app/androi...
blimp/client/app/android/java/res/values/arrays.xml:19: <!-- These need to port
to Chrome in the future. -->
On 2016/07/22 16:51:42, David Trainor wrote:
> Could you explain why?  If we do need to, file a bug and reference it here.

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java:48:
public  void attachBlimpPreferences(PreferenceFragment fragment,
On 2016/07/22 16:51:42, David Trainor wrote:
> Remove extra space

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:20:
// import org.chromium.chrome.browser.ApplicationLifetime;
On 2016/07/22 16:51:42, David Trainor wrote:
> ?

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:28:
private static final String PREF_ASSIGNER_URL = "blimp_assigner_url";
On 2016/07/22 16:51:42, David Trainor wrote:
> Public as well.  And javadocs for both :).  Or helper methods?

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:70:
// An alternative is to use {@link ChromeSwitchPreference}.
On 2016/07/22 16:51:42, David Trainor wrote:
> Can you add a TODO and a bug for when this is moved out of blimp/?

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:131:
private static void restartBrowser(Context context) {
On 2016/07/22 16:51:42, David Trainor wrote:
> Do we need the context?

Done.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:133:
sSettingsCallback.onRestartBrowserRequested();
On 2016/07/22 16:51:42, David Trainor wrote:
> Just to confirm, there's no way to avoid restarting right?  If so, we should
> undo the preference changes that were made or something.

Not sure why we need undo the preferences, is it set the switch to default after
changing the assigner url?

https://codereview.chromium.org/2173563003/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpPreferencesTest.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpPreferencesTest.java:22:
public class BlimpPreferencesTest extends ChromeTabbedActivityTestBase {
On 2016/07/22 16:51:43, David Trainor wrote:
> Can we just test that the fragment loads and that we get valid callbacks and
> shared pref values?  We could put this test inside blimp/ and avoid the
> integration issues.

Done. Moved the test code to blimp also.

https://codereview.chromium.org/2173563003/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/blimp/BlimpPreferencesTest.java:23:
public static final String PREF_BLIMP_SWITCH = "blimp_switch";
On 2016/07/22 16:51:43, David Trainor wrote:
> private?

Done. Removed this and use const string in another class.

[commit-bot: I haz the power, 2016-07-24 00:13:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-24 00:13:13]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-07-25 18:25:11]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 18:25:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 21:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 21:04:10]

Dry run: This issue passed the CQ dry run.

[David Trainor- moved to gerrit, 2016-07-27 17:31:34]

lgtm % small nits.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:133:
sSettingsCallback.onRestartBrowserRequested();
On 2016/07/23 23:50:36, xingliu wrote:
> On 2016/07/22 16:51:42, David Trainor wrote:
> > Just to confirm, there's no way to avoid restarting right?  If so, we should
> > undo the preference changes that were made or something.
> 
> Not sure why we need undo the preferences, is it set the switch to default
after
> changing the assigner url? 

I just meant the restart dialog (and subsequent restart) is unavoidable once
they reach this point right?

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/app/andro...
File
blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java
(right):

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/app/andro...
blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java:28:
private void launchAcitivity() {
Acitivity -> Activity

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/core/andr...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java
(right):

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/core/andr...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java:17:
* @return The saved value of assigner preference, or empty string if we didn't
found the
found -> find.

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/core/andr...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java:20:
public static String getLastUsedAssigner() {
Where do we pull the default assigner URL?  Would it make more sense to just
expose the proper assigner through here?  I'll probably see it when I look at
the assigner code nyquist@ is moving over :).

[xingliu, 2016-07-27 21:10:09]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 21:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:04:45]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-07-27 23:52:04]

Fix issues based on review, prepare to put it into commit queue.

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java
(right):

https://codereview.chromium.org/2173563003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/AboutBlimpPreferences.java:133:
sSettingsCallback.onRestartBrowserRequested();
On 2016/07/27 17:31:34, David Trainor wrote:
> On 2016/07/23 23:50:36, xingliu wrote:
> > On 2016/07/22 16:51:42, David Trainor wrote:
> > > Just to confirm, there's no way to avoid restarting right?  If so, we
should
> > > undo the preference changes that were made or something.
> > 
> > Not sure why we need undo the preferences, is it set the switch to default
> after
> > changing the assigner url? 
> 
> I just meant the restart dialog (and subsequent restart) is unavoidable once
> they reach this point right?

Oh, restart will be triggered only if user clicks a button in the dialog. User
can tap elsewhere to dismiss the dialog and not to restart.

If we need to force the user to quit, I can do it in next OAuth token CL(token
is almost done). AlertDialog can control that behavior(if user can tap outside
to dismiss or press backbutton to dismiss).

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/app/andro...
File
blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java
(right):

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/app/andro...
blimp/client/app/android/javatests/src/org/chromium/blimp/core/settings/BlimpPreferencesTest.java:28:
private void launchAcitivity() {
On 2016/07/27 17:31:34, David Trainor wrote:
> Acitivity -> Activity

Done.

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/core/andr...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java
(right):

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/core/andr...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java:17:
* @return The saved value of assigner preference, or empty string if we didn't
found the
On 2016/07/27 17:31:34, David Trainor wrote:
> found -> find.

Done.

https://codereview.chromium.org/2173563003/diff/120001/blimp/client/core/andr...
blimp/client/core/android/java/src/org/chromium/blimp/core/settings/PreferencesUtil.java:20:
public static String getLastUsedAssigner() {
On 2016/07/27 17:31:34, David Trainor wrote:
> Where do we pull the default assigner URL?  Would it make more sense to just
> expose the proper assigner through here?  I'll probably see it when I look at
> the assigner code nyquist@ is moving over :).

This makes sense, I'll expose the default development assigner here.

[xingliu, 2016-07-27 23:52:23]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-07-27 23:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2173563003/#ps140001
(title: "Fix nit issues, and prepare to commit.")

[commit-bot: I haz the power, 2016-07-27 23:52:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:58:59]

Description was changed from

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.


Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 


In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.


For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451
==========

to

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.


Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 


In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.


For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451
==========

[commit-bot: I haz the power, 2016-07-27 23:59:01]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-07-28 00:02:08]

Description was changed from

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.


Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed) 


In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.


For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451
==========

to

==========
Blimp settings UI integration for Chrome, everything still lives in Blimp.

Previously Blimp code is in blimp/app, this CL port settings UI code to core,
and reuse Java resources files in blimp/app.(We can setup new one in core or
somewhere if needed)

In this way, all UI resources, and code live in Blimp so we don't leak things to
Chrome at the moment.

For Chrome, it needs to throw a callback interface to Blimp, so Blimp can ask
Chrome to do things in java.

The CL that port UI code and resources into Chrome will be deleted.

BUG=624451

Committed: https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151
Cr-Commit-Position: refs/heads/master@{#408281}
==========

[commit-bot: I haz the power, 2016-07-28 00:02:10]

Patchset 8 (id:??) landed as
https://crrev.com/27752d3ef4b6b938bcc3533797348fca37346151
Cr-Commit-Position: refs/heads/master@{#408281}