Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5034)

Unified Diff: blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java

Issue 2173563003: Blimp settings UI integration for Chrome, everything still lives in Blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nit issues, and prepare to commit. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
diff --git a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java b/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
index ea547729d3a186625ea938ca98fb9758e0f1f845..774f9de33fb6d80426aacb270e34720ae894413e 100644
--- a/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
+++ b/blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
@@ -4,9 +4,13 @@
package org.chromium.blimp.core;
+import android.preference.PreferenceFragment;
+
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.JNINamespace;
+import org.chromium.blimp.core.settings.AboutBlimpPreferences;
import org.chromium.blimp_public.BlimpClientContext;
+import org.chromium.blimp_public.BlimpSettingsCallbacks;
import org.chromium.blimp_public.contents.BlimpContents;
/**
@@ -35,6 +39,18 @@ public class BlimpClientContextImpl implements BlimpClientContext {
return nativeCreateBlimpContents(mNativeBlimpClientContextImplAndroid);
}
+ @Override
+ public boolean isBlimpSupported() {
+ return true;
+ }
+
+ @Override
+ public void attachBlimpPreferences(PreferenceFragment fragment,
+ BlimpSettingsCallbacks callbacks) {
+ AboutBlimpPreferences.addBlimpPreferences(fragment);
+ AboutBlimpPreferences.registerCallback(callbacks);
+ }
+
@CalledByNative
private void clearNativePtr() {
mNativeBlimpClientContextImplAndroid = 0;
« no previous file with comments | « blimp/client/core/BUILD.gn ('k') | blimp/client/core/android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698