blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java - Issue 2173563003: Blimp settings UI integration for Chrome, everything still lives in Blimp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

Issue 2173563003: Blimp settings UI integration for Chrome, everything still lives in Blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nit issues, and prepare to commit. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/public/BUILD.gn ('k') | blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpSettingsCallbacks.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

diff --git a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

index 761fc17b76445bf87827daa70bb7338fd5967712..71fd5229e17c7eb811e4b5935a0ea189a34e18a5 100644

--- a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

+++ b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

@@ -4,6 +4,8 @@

package org.chromium.blimp_public;

+import android.preference.PreferenceFragment;

import org.chromium.blimp_public.contents.BlimpContents;

/**

@@ -19,4 +21,16 @@ public interface BlimpClientContext {

* {@link BlimpContents#destroy()} for destruction of the BlimpContents.

BlimpContents createBlimpContents();

+ /**

+ * @return If Blimp is supported with this build.

+ */

+ boolean isBlimpSupported();

+ /**

+ * Attach blimp settings UI to a {@link PreferenceFragment}

+ * @param fragment PreferenceFragment that blimp settings UI attached to.

+ * @param callback Chrome layer callbacks that passed to Blimp.

+ */

+ void attachBlimpPreferences(PreferenceFragment fragment, BlimpSettingsCallbacks callback);

}