Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 21735005: Use "int" instead of "long" for bindings where the WebIDL uses "long". (Closed)

Created:
7 years, 4 months ago by eroman
Modified:
6 years, 1 month ago
CC:
blink-reviews, eae+blinkwatch, tommyw+watchlist_chromium.org, feature-media-reviews_chromium.org, dglazkov+blink, dgrogan, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

ABANDONED!!! Use "int" instead of "long" for bindings where the WebIDL uses "long". BUG=267360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -55 lines) Patch
M Source/core/html/track/TextTrackRegion.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackRegion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathResult.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathResult.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediasource/SourceBufferList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechGrammarList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechGrammarList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResult.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognitionResultList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocket.h View 3 chunks +4 lines, -2 lines 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
7 years, 4 months ago (2013-08-02 07:31:00 UTC) #1
alecflett
lgtm for the indexeddb stuff - though dgrogan@ may want to take a look at ...
7 years, 4 months ago (2013-08-02 15:10:14 UTC) #2
eroman
abarth: ping. Should I break this into separate changelists, or abandon?
7 years, 4 months ago (2013-08-13 15:38:10 UTC) #3
jsbell
7 years, 4 months ago (2013-08-13 18:12:40 UTC) #4
For readability, would it be better to use int32 instead of int?

"The IDL says long. Why does the header say int? Is this a bug?" => the reader
needs to go off and read
http://en.wikipedia.org/wiki/64-bit_computing#64-bit_data_models and understand
that sizeof(long) varies across architectures/compilers/OS, and
http://dev.w3.org/2006/webapi/WebIDL/#idl-long to understand that an IDL long is
32 bits.

"The IDL says long. The header says int32" => the reader (correctly) assumes
that IDL long is 32 bits.

(Assuming the reader is at all like me, at least.)

Powered by Google App Engine
This is Rietveld 408576698