Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: Source/modules/websockets/WebSocket.h

Issue 21735005: Use "int" instead of "long" for bindings where the WebIDL uses "long". (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/websockets/WebSocket.h
diff --git a/Source/modules/websockets/WebSocket.h b/Source/modules/websockets/WebSocket.h
index 229f7f59c1fa80addb435894ea6ffcfd81beaa51..72a920e809778cd32b088c1799a4246b1b6be3d4 100644
--- a/Source/modules/websockets/WebSocket.h
+++ b/Source/modules/websockets/WebSocket.h
@@ -85,7 +85,7 @@ public:
const KURL& url() const;
State readyState() const;
- unsigned long bufferedAmount() const;
+ unsigned bufferedAmount() const;
String protocol() const;
String extensions() const;
@@ -117,6 +117,7 @@ public:
virtual void didReceiveMessage(const String& message) OVERRIDE;
virtual void didReceiveBinaryData(PassOwnPtr<Vector<char> >) OVERRIDE;
virtual void didReceiveMessageError() OVERRIDE;
+ // FIXME: bufferedAmount should be an "unsigned int".
virtual void didUpdateBufferedAmount(unsigned long bufferedAmount) OVERRIDE;
virtual void didStartClosingHandshake() OVERRIDE;
virtual void didClose(unsigned long unhandledBufferedAmount, ClosingHandshakeCompletionStatus, unsigned short code, const String& reason) OVERRIDE;
@@ -154,7 +155,8 @@ private:
State m_state;
KURL m_url;
EventTargetData m_eventTargetData;
- unsigned long m_bufferedAmount;
+ unsigned m_bufferedAmount;
+ // FIXME: Can this just be "unsigned" too?
unsigned long m_bufferedAmountAfterClose;
BinaryType m_binaryType;
String m_subprotocol;
« no previous file with comments | « Source/modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp ('k') | Source/modules/websockets/WebSocket.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698