Source/modules/indexeddb/IDBFactory.h - Issue 21735005: Use "int" instead of "long" for bindings where the WebIDL uses "long".

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/indexeddb/IDBFactory.h

Issue 21735005: Use "int" instead of "long" for bindings where the WebIDL uses "long". (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/modules/indexeddb/IDBCursor.cpp ('k') | Source/modules/mediasource/SourceBufferList.h » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Google Inc. All rights reserved.	2 * Copyright (C) 2010 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55	55

56 PassRefPtr<IDBOpenDBRequest> open(ScriptExecutionContext*, const String& nam e, ExceptionState&);	56 PassRefPtr<IDBOpenDBRequest> open(ScriptExecutionContext*, const String& nam e, ExceptionState&);

57 PassRefPtr<IDBOpenDBRequest> open(ScriptExecutionContext*, const String& nam e, unsigned long long version, ExceptionState&);	57 PassRefPtr<IDBOpenDBRequest> open(ScriptExecutionContext*, const String& nam e, unsigned long long version, ExceptionState&);

58 PassRefPtr<IDBOpenDBRequest> deleteDatabase(ScriptExecutionContext*, const S tring& name, ExceptionState&);	58 PassRefPtr<IDBOpenDBRequest> deleteDatabase(ScriptExecutionContext*, const S tring& name, ExceptionState&);

59	59

60 short cmp(ScriptExecutionContext*, const ScriptValue& first, const ScriptVal ue& second, ExceptionState&);	60 short cmp(ScriptExecutionContext*, const ScriptValue& first, const ScriptVal ue& second, ExceptionState&);

61	61

62 private:	62 private:

63 IDBFactory(IDBFactoryBackendInterface*);	63 IDBFactory(IDBFactoryBackendInterface*);

64	64

	65 // FIXME: Seems there is a sign mismatch between version (signed) and that i n open (unsigned)

65 PassRefPtr<IDBOpenDBRequest> openInternal(ScriptExecutionContext*, const Str ing& name, int64_t version, ExceptionState&);	66 PassRefPtr<IDBOpenDBRequest> openInternal(ScriptExecutionContext*, const Str ing& name, int64_t version, ExceptionState&);

66	67

67 RefPtr<IDBFactoryBackendInterface> m_backend;	68 RefPtr<IDBFactoryBackendInterface> m_backend;

68 };	69 };

69	70

70 } // namespace WebCore	71 } // namespace WebCore

71	72

72 #endif // IDBFactory_h	73 #endif // IDBFactory_h

OLD	NEW