Convert ios_web_shell_test to GN.

Convert ios_web_shell_test to GN.

BUG=629867
Committed: https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315
Cr-Commit-Position: refs/heads/master@{#407159}

[sdefresne, 2016-07-21 18:18:39]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-07-21 18:19:05]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-07-21 18:19:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-07-21 18:20:34]

sdefresne@chromium.org changed reviewers:
+ baxley@chromium.org, justincohen@chromium.org, rohitrao@chromium.org

[sdefresne, 2016-07-21 18:20:34]

sdefresne@chromium.org changed required reviewers:
+ justincohen@chromium.org

[sdefresne, 2016-07-21 18:20:35]

justincohen: Please take a look.

baxley/rohitrao: FYI, once this CL lands, we'll have ios_web_shell_test EarlGrey
tests running with gn and we can start converting the downstream targets after
it rolls

[commit-bot: I haz the power, 2016-07-21 18:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:29:38]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[justincohen, 2016-07-21 18:42:05]

lgtm

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
File ios/third_party/earl_grey/BUILD.gn (right):

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
ios/third_party/earl_grey/BUILD.gn:272:
"$_ios_platform_library/Frameworks/XCTest.framework",
Should this be a part of gn instead of earl grey?  If we ever add other xctests
that aren't earl grey, we will still need this.

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
File ios/third_party/earl_grey/xctest_shell.mm (right):

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
ios/third_party/earl_grey/xctest_shell.mm:20: - (void)testThatShouldPass {
Does this need to be an xctest at all?  the empty shell_test.mm we use currently
just compiles an unused EmptyFile NSobject.?

https://codereview.chromium.org/2173493002/diff/20001/ios/web/shell/test/shel...
File ios/web/shell/test/shell_test.mm (right):

https://codereview.chromium.org/2173493002/diff/20001/ios/web/shell/test/shel...
ios/web/shell/test/shell_test.mm:8: @interface EmptyTests : XCTestCase
Same here

[sdefresne, 2016-07-22 13:13:33]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 13:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 13:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 13:15:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sdefresne, 2016-07-22 13:24:32]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 13:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 13:28:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 13:28:59]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[sdefresne, 2016-07-22 13:31:57]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-07-22 13:32:08]

Thank you for the review.

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
File ios/third_party/earl_grey/BUILD.gn (right):

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
ios/third_party/earl_grey/BUILD.gn:272:
"$_ios_platform_library/Frameworks/XCTest.framework",
On 2016/07/21 18:42:05, justincohen wrote:
> Should this be a part of gn instead of earl grey?  If we ever add other
xctests
> that aren't earl grey, we will still need this.

Good idea, I've split the ios_eg_tests in two xctests and eg_tests (with
eg_tests just a wrapper around xctest that add dependencies on earl_grey).

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
File ios/third_party/earl_grey/xctest_shell.mm (right):

https://codereview.chromium.org/2173493002/diff/20001/ios/third_party/earl_gr...
ios/third_party/earl_grey/xctest_shell.mm:20: - (void)testThatShouldPass {
On 2016/07/21 18:42:05, justincohen wrote:
> Does this need to be an xctest at all?  the empty shell_test.mm we use
currently
> just compiles an unused EmptyFile NSobject.?

No, changed to a empty class like in shell_test.mm

https://codereview.chromium.org/2173493002/diff/20001/ios/web/shell/test/shel...
File ios/web/shell/test/shell_test.mm (right):

https://codereview.chromium.org/2173493002/diff/20001/ios/web/shell/test/shel...
ios/web/shell/test/shell_test.mm:8: @interface EmptyTests : XCTestCase
On 2016/07/21 18:42:05, justincohen wrote:
> Same here

Reverted.

[commit-bot: I haz the power, 2016-07-22 13:32:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 13:39:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 13:39:08]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)

[sdefresne, 2016-07-22 14:08:34]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 14:08:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-07-22 14:19:29]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2016-07-22 14:19:31]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-07-22 14:19:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2173493002/#ps100001
(title: "Sync //ios/web/shell/test:earl_grey_test_support with gyp.")

[commit-bot: I haz the power, 2016-07-22 14:19:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 14:54:02]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-07-22 14:55:20]

Description was changed from

==========
Convert ios_web_shell_test to GN.

BUG=629867
==========

to

==========
Convert ios_web_shell_test to GN.

BUG=629867

Committed: https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315
Cr-Commit-Position: refs/heads/master@{#407159}
==========

[commit-bot: I haz the power, 2016-07-22 14:55:21]

Patchset 5 (id:??) landed as
https://crrev.com/cdf365d050f4d1a86c42818b3e1f760eedfc4315
Cr-Commit-Position: refs/heads/master@{#407159}