ios/third_party/earl_grey/xctest_shell.mm - Issue 2173493002: Convert ios_web_shell_test to GN.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/third_party/earl_grey/xctest_shell.mm

Issue 2173493002: Convert ios_web_shell_test to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@eg-tests-deps

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import <UIKit/UIKit.h>

	6 #import <XCTest/XCTest.h>

	7

	8 // For Chrome on iOS we want to run EarlGrey tests (that are XCTests) for all

	9 // our build configurations (Debug, Release, ...). In addition, the symbols

	10 // visibility is configured to private by default. To simplify testing with

	11 // those constraints, our tests are compiled in the TEST_HOST target instead

	12 // of the .xctest bundle that all link against this single test (just there to

	13 // ensure that the bundle is not empty).

	14

	15 @interface XCTestShellTests : XCTestCase

	16 @end

	17

	18 @implementation XCTestShellTests

	19

	20 - (void)testThatShouldPass {
	justincohen 2016/07/21 18:42:05 Does this need to be an xctest at all? the empty Does this need to be an xctest at all? the empty shell_test.mm we use currently just compiles an unused EmptyFile NSobject.? sdefresne 2016/07/22 13:32:08 No, changed to a empty class like in shell_test.mm Show quoted text On 2016/07/21 18:42:05, justincohen wrote: > Does this need to be an xctest at all? the empty shell_test.mm we use currently > just compiles an unused EmptyFile NSobject.? No, changed to a empty class like in shell_test.mm
	21 }

	22

	23 @end

OLD	NEW