Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: ios/third_party/earl_grey/BUILD.gn

Issue 2173493002: Convert ios_web_shell_test to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@eg-tests-deps
Patch Set: Sync //ios/web/shell/test:earl_grey_test_support with gyp. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/BUILD.gn ('k') | ios/third_party/earl_grey/ios_eg_test.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/third_party/earl_grey/BUILD.gn
diff --git a/ios/third_party/earl_grey/BUILD.gn b/ios/third_party/earl_grey/BUILD.gn
index c6ab791658f73f129a04d96cd5da01d4afc4ad59..1c515ef65df31afe221575dc48377e89391482a2 100644
--- a/ios/third_party/earl_grey/BUILD.gn
+++ b/ios/third_party/earl_grey/BUILD.gn
@@ -7,13 +7,6 @@ import("//build/config/ios/rules.gni")
config("config") {
include_dirs = [ "src/EarlGrey" ]
-
- # EarlGrey and its dependencies need to link to XCTest.framework
- # that is not under $ios_sdk_path.
- common_flags = [ "-F$ios_sdk_path/../../Library/Frameworks" ]
- cflags_objc = common_flags
- cflags_objcc = common_flags
- ldflags = common_flags
}
ios_framework_bundle("earl_grey") {
@@ -258,7 +251,11 @@ ios_framework_bundle("earl_grey") {
"XCTest.framework",
]
- public_configs = [ ":config" ]
+ public_configs = [
+ ":config",
+ "//build/config/ios:xctest_config",
+ ]
+
configs += [ "//build/config/compiler:enable_arc" ]
configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
configs += [ "//build/config/gcc:symbol_visibility_default" ]
« no previous file with comments | « ios/BUILD.gn ('k') | ios/third_party/earl_grey/ios_eg_test.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698