[DevTools] Better locations for snippets

[DevTools] Better locations for snippets

- highlight errors in snippet source;
- fix location of Syntax Errors in console messge;
- fix location of Snippet result in console message

BUG=479712
R=lushnikov@chromium.org

Committed: https://crrev.com/897ee2fbd5f124e9c99131e1919b512acfb78e60
Cr-Commit-Position: refs/heads/master@{#407706}

[kozy, 2016-07-22 21:59:57]

Andrey, please take a look!

[lushnikov, 2016-07-25 22:31:21]

sweet! Thank you!

May we have a test to fixate this?

[kozy, 2016-07-26 00:47:36]

Patchset #3 (id:40001) has been deleted

[kozy, 2016-07-26 00:48:30]

Added a test. Please take a look!

[lushnikov, 2016-07-26 01:05:29]

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html
(right):

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:19:
.then((uiSourceCode) => selectSourceCode(uiSourceCode))
let's remove ()

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:57:
function createSnippetPromise(content)
let's use this content

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:59:
var cb;
we don't use abbreviations in blink

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:82:
uiSourceCode.addLineMessage = function(level, text, lineNumber, columnNumber)
let's make named function

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:82:
uiSourceCode.addLineMessage = function(level, text, lineNumber, columnNumber)
let's make a sniffer and dump uiSourceCode URL

[kozy, 2016-07-26 01:34:16]

all done. ptal!

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html
(right):

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:19:
.then((uiSourceCode) => selectSourceCode(uiSourceCode))
On 2016/07/26 01:05:29, lushnikov wrote:
> let's remove ()

Done.

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:57:
function createSnippetPromise(content)
On 2016/07/26 01:05:29, lushnikov wrote:
> let's use this content

Done.

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:59:
var cb;
On 2016/07/26 01:05:29, lushnikov wrote:
> we don't use abbreviations in blink

Done.

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:82:
uiSourceCode.addLineMessage = function(level, text, lineNumber, columnNumber)
On 2016/07/26 01:05:29, lushnikov wrote:
> let's make a sniffer and dump uiSourceCode URL

Done.

https://codereview.chromium.org/2173233002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html:82:
uiSourceCode.addLineMessage = function(level, text, lineNumber, columnNumber)
On 2016/07/26 01:05:29, lushnikov wrote:
> let's make named function

Acknowledged.

[kozy, 2016-07-26 01:34:58]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 01:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2016-07-26 01:41:28]

lgtm, thanks!

[kozy, 2016-07-26 01:44:20]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-07-26 01:44:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2173233002/#ps80001
(title: "")

[commit-bot: I haz the power, 2016-07-26 01:44:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 04:18:56]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-07-26 04:20:14]

Description was changed from

==========
[DevTools] Better locations for snippets

- highlight errors in snippet source;
- fix location of Syntax Errors in console messge;
- fix location of Snippet result in console message

BUG=479712
R=lushnikov@chromium.org
==========

to

==========
[DevTools] Better locations for snippets

- highlight errors in snippet source;
- fix location of Syntax Errors in console messge;
- fix location of Snippet result in console message

BUG=479712
R=lushnikov@chromium.org

Committed: https://crrev.com/897ee2fbd5f124e9c99131e1919b512acfb78e60
Cr-Commit-Position: refs/heads/master@{#407706}
==========

[commit-bot: I haz the power, 2016-07-26 04:20:16]

Patchset 4 (id:??) landed as
https://crrev.com/897ee2fbd5f124e9c99131e1919b512acfb78e60
Cr-Commit-Position: refs/heads/master@{#407706}