Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html

Issue 2173233002: [DevTools] Better locations for snippets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html b/third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html
new file mode 100644
index 0000000000000000000000000000000000000000..ae95b7bc347d9cdbb85b02d5f867c7f492bab3f2
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html
@@ -0,0 +1,90 @@
+<html>
+<head>
+<script src="../../http/tests/inspector/inspector-test.js"></script>
+<script src="../../http/tests/inspector/sources-test.js"></script>
+<script src="../../http/tests/inspector/console-test.js"></script>
+<script>
+
+function test()
+{
+ InspectorTest.addSniffer(WebInspector.UISourceCode.prototype, "addLineMessage", dumpLineMessage, true);
+
+ InspectorTest.runTestSuite([
+ function testConsoleLogAndReturnMessageLocation(next)
+ {
+ InspectorTest.waitUntilNthMessageReceivedPromise(2)
+ .then(() => InspectorTest.dumpConsoleMessages())
+ .then(() => WebInspector.ConsoleView.clearConsole())
+ .then(() => next());
+
+ createSnippetPromise("console.log(239);42")
+ .then(uiSourceCode => selectSourceCode(uiSourceCode))
+ .then(uiSourceCode => renameSourceCodePromise("name1", uiSourceCode))
+ .then(() => runSelectedSnippet());
+ },
+
+ function testSnippetSyntaxError(next)
+ {
+ InspectorTest.waitUntilNthMessageReceivedPromise(1)
+ .then(() => InspectorTest.dumpConsoleMessages())
+ .then(() => WebInspector.ConsoleView.clearConsole())
+ .then(() => next());
+
+ createSnippetPromise("\n }")
+ .then(uiSourceCode => selectSourceCode(uiSourceCode))
+ .then(uiSourceCode => renameSourceCodePromise("name2", uiSourceCode))
+ .then(() => runSelectedSnippet());
+ },
+
+ function testConsoleErrorHighlight(next)
+ {
+ InspectorTest.waitUntilNthMessageReceivedPromise(1)
+ .then(() => InspectorTest.dumpConsoleMessages())
+ .then(() => WebInspector.ConsoleView.clearConsole())
+ .then(() => next());
+
+ createSnippetPromise("\n console.error(42);")
+ .then(uiSourceCode => selectSourceCode(uiSourceCode))
+ .then(uiSourceCode => renameSourceCodePromise("name3", uiSourceCode))
+ .then(() => runSelectedSnippet());
+ }
+ ]);
+
+ function createSnippetPromise(content)
+ {
+ var callback;
+ var promise = new Promise(fullfill => callback = fullfill);
+ WebInspector.scriptSnippetModel._project.createFile("", null, content, callback);
+ return promise;
+ }
+
+ function renameSourceCodePromise(newName, uiSourceCode)
+ {
+ var callback;
+ var promise = new Promise(fullfill => callback = fullfill);
+ uiSourceCode.rename(newName, () => callback(uiSourceCode));
+ return promise;
+ }
+
+ function selectSourceCode(uiSourceCode)
+ {
+ WebInspector.SourcesPanel.instance()._sourceSelected({ data: { uiSourceCode: uiSourceCode }});
+ return uiSourceCode;
+ }
+
+ function dumpLineMessage(level, text, lineNumber, columnNumber)
+ {
+ InspectorTest.addResult(`Line Message was added: ${this.url()} ${level} '${text}':${lineNumber}:${columnNumber}`);
+ }
+
+ function runSelectedSnippet()
+ {
+ WebInspector.SourcesPanel.instance()._runSnippet();
+ }
+}
+</script>
+</head>
+<body onload="runTest()">
+<p>Test that link to snippet works.</p>
+</body>
+</html>

Powered by Google App Engine
This is Rietveld 408576698