third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html - Issue 2173233002: [DevTools] Better locations for snippets

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet.html

Issue 2173233002: [DevTools] Better locations for snippets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added a test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js ('k') | third_party/WebKit/LayoutTests/inspector/console/console-link-to-snippet-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../http/tests/inspector/inspector-test.js"></script>

	4 <script src="../../http/tests/inspector/sources-test.js"></script>

	5 <script src="../../http/tests/inspector/console-test.js"></script>

	6 <script>

	7

	8 function test()

	9 {

	10 InspectorTest.runTestSuite([

	11 function testConsoleLogAndReturnMessageLocation(next)

	12 {

	13 InspectorTest.waitUntilNthMessageReceivedPromise(2)

	14 .then(() => InspectorTest.dumpConsoleMessages())

	15 .then(() => WebInspector.ConsoleView.clearConsole())

	16 .then(() => next());

	17

	18 createSnippetPromise()

	19 .then((uiSourceCode) => selectSourceCode(uiSourceCode))
	lushnikov 2016/07/26 01:05:29 let's remove () let's remove () kozy 2016/07/26 01:34:15 Done. Show quoted text On 2016/07/26 01:05:29, lushnikov wrote: > let's remove () Done.
	20 .then((uiSourceCode) => renameSourceCodePromise("name1", uiSourc eCode))

	21 .then((uiSourceCode) => addLineMessageSniffer(uiSourceCode))

	22 .then((uiSourceCode) => uiSourceCode.setWorkingCopy("console.log (239);42"))

	23 .then(() => runSelectedSnippet());

	24 },

	25

	26 function testSnippetSyntaxError(next)

	27 {

	28 InspectorTest.waitUntilNthMessageReceivedPromise(1)

	29 .then(() => InspectorTest.dumpConsoleMessages())

	30 .then(() => WebInspector.ConsoleView.clearConsole())

	31 .then(() => next());

	32

	33 createSnippetPromise()

	34 .then((uiSourceCode) => selectSourceCode(uiSourceCode))

	35 .then((uiSourceCode) => renameSourceCodePromise("name2", uiSourc eCode))

	36 .then((uiSourceCode) => addLineMessageSniffer(uiSourceCode))

	37 .then((uiSourceCode) => uiSourceCode.setWorkingCopy("\n }"))

	38 .then(() => runSelectedSnippet());

	39 },

	40

	41 function testConsoleErrorHighlight(next)

	42 {

	43 InspectorTest.waitUntilNthMessageReceivedPromise(1)

	44 .then(() => InspectorTest.dumpConsoleMessages())

	45 .then(() => WebInspector.ConsoleView.clearConsole())

	46 .then(() => next());

	47

	48 createSnippetPromise()

	49 .then((uiSourceCode) => selectSourceCode(uiSourceCode))

	50 .then((uiSourceCode) => renameSourceCodePromise("name3", uiSourc eCode))

	51 .then((uiSourceCode) => addLineMessageSniffer(uiSourceCode))

	52 .then((uiSourceCode) => uiSourceCode.setWorkingCopy("\n console .error(42);"))

	53 .then(() => runSelectedSnippet());

	54 }

	55 ]);

	56

	57 function createSnippetPromise(content)
	lushnikov 2016/07/26 01:05:29 let's use this content let's use this content kozy 2016/07/26 01:34:15 Done. Show quoted text On 2016/07/26 01:05:29, lushnikov wrote: > let's use this content Done.
	58 {

	59 var cb;
	lushnikov 2016/07/26 01:05:29 we don't use abbreviations in blink we don't use abbreviations in blink kozy 2016/07/26 01:34:15 Done. Show quoted text On 2016/07/26 01:05:29, lushnikov wrote: > we don't use abbreviations in blink Done.
	60 var p = new Promise(f => cb = f);

	61 WebInspector.scriptSnippetModel._project.createFile("", null, content, c b);

	62 return p;

	63 }

	64

	65 function renameSourceCodePromise(newName, uiSourceCode)

	66 {

	67 var cb;

	68 var p = new Promise(f => cb = f);

	69 uiSourceCode.rename(newName, () => cb(uiSourceCode));

	70 return p;

	71 }

	72

	73 function selectSourceCode(uiSourceCode)

	74 {

	75 WebInspector.SourcesPanel.instance()._sourceSelected({ data: { uiSourceC ode: uiSourceCode }});

	76 return uiSourceCode;

	77 }

	78

	79 function addLineMessageSniffer(uiSourceCode)

	80 {

	81 var orig = uiSourceCode.addLineMessage;

	82 uiSourceCode.addLineMessage = function(level, text, lineNumber, columnNu mber)
	lushnikov 2016/07/26 01:05:29 let's make a sniffer and dump uiSourceCode URL let's make a sniffer and dump uiSourceCode URL lushnikov 2016/07/26 01:05:29 let's make named function let's make named function kozy 2016/07/26 01:34:15 Acknowledged. Show quoted text On 2016/07/26 01:05:29, lushnikov wrote: > let's make named function Acknowledged. kozy 2016/07/26 01:34:15 Done. Show quoted text On 2016/07/26 01:05:29, lushnikov wrote: > let's make a sniffer and dump uiSourceCode URL Done.
	83 {

	84 InspectorTest.addResult(`Line Message was added: ${level} '${text}': ${lineNumber}:${columnNumber}`);

	85 orig.call(uiSourceCode, level, text, lineNumber, columnNumber);

	86 }

	87 return uiSourceCode;

	88 }

	89

	90 function runSelectedSnippet()

	91 {

	92 WebInspector.SourcesPanel.instance()._runSnippet();

	93 }

	94 }

	95 </script>

	96 </head>

	97 <body onload="runTest()">

	98 <p>Test that link to snippet works.</p>

	99 </body>

	100 </html>

OLD	NEW