Make various views SetShape() methods take an unique_ptr.

Make various views SetShape() methods take unique_ptrs.

Committed: https://crrev.com/2df98d87938c41d13c367f94f8621f4fe7543542
Cr-Commit-Position: refs/heads/master@{#407534}

[Lei Zhang, 2016-07-22 09:45:44]

Description was changed from

==========
Make various views SetShape() methods take an unique_ptr.
==========

to

==========
Make various views SetShape() methods take unique_ptrs.
==========

[Lei Zhang, 2016-07-22 09:45:49]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 10:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 10:41:14]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-07-22 10:52:48]

thestig@chromium.org changed reviewers:
+ sadrul@chromium.org

[sadrul, 2016-07-23 00:59:16]

Thanks for the cleanup! lgtm

https://codereview.chromium.org/2173033002/diff/1/chrome/browser/ui/views/app...
File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (right):

https://codereview.chromium.org/2173033002/diff/1/chrome/browser/ui/views/app...
chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:358:
base::WrapUnique(shape() ? new SkRegion(*shape()) : nullptr));
This could also be:

  shape() ? base::MakeUnique<SkRegion>(*shape()) : nullptr

https://codereview.chromium.org/2173033002/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc (right):

https://codereview.chromium.org/2173033002/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc:320: const float&
scale = display::win::GetDPIScale();
weird to use a ref here.

[Lei Zhang, 2016-07-25 17:57:00]

https://codereview.chromium.org/2173033002/diff/1/chrome/browser/ui/views/app...
File chrome/browser/ui/views/apps/chrome_native_app_window_views.cc (right):

https://codereview.chromium.org/2173033002/diff/1/chrome/browser/ui/views/app...
chrome/browser/ui/views/apps/chrome_native_app_window_views.cc:358:
base::WrapUnique(shape() ? new SkRegion(*shape()) : nullptr));
On 2016/07/23 00:59:16, sadrul wrote:
> This could also be:
> 
>   shape() ? base::MakeUnique<SkRegion>(*shape()) : nullptr

Done.

https://codereview.chromium.org/2173033002/diff/1/ui/views/widget/desktop_aur...
File ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc (right):

https://codereview.chromium.org/2173033002/diff/1/ui/views/widget/desktop_aur...
ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc:320: const float&
scale = display::win::GetDPIScale();
On 2016/07/23 00:59:16, sadrul wrote:
> weird to use a ref here.

Indeed. It's copy + paste... and fixed.

[Lei Zhang, 2016-07-25 17:57:05]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-07-25 17:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2173033002/#ps20001
(title: "nits")

[commit-bot: I haz the power, 2016-07-25 17:57:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 18:55:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-25 18:59:14]

Description was changed from

==========
Make various views SetShape() methods take unique_ptrs.
==========

to

==========
Make various views SetShape() methods take unique_ptrs.

Committed: https://crrev.com/2df98d87938c41d13c367f94f8621f4fe7543542
Cr-Commit-Position: refs/heads/master@{#407534}
==========

[commit-bot: I haz the power, 2016-07-25 18:59:15]

Patchset 2 (id:??) landed as
https://crrev.com/2df98d87938c41d13c367f94f8621f4fe7543542
Cr-Commit-Position: refs/heads/master@{#407534}