ui/views/widget/desktop_aura/desktop_native_widget_aura.cc - Issue 2173033002: Make various views SetShape() methods take an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

Issue 2173033002: Make various views SetShape() methods take an unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/views/widget/desktop_aura/desktop_native_widget_aura.h ('k') | ui/views/widget/desktop_aura/desktop_window_tree_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

index 5afea837c015ab06bf31d18bdb3aeeabadc61212..b19ee7f72780eb9ea16faf01cb956c4538ba34b6 100644

--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

@@ -707,9 +707,9 @@ void DesktopNativeWidgetAura::StackAtTop() {

void DesktopNativeWidgetAura::StackBelow(gfx::NativeView native_view) {

}

-void DesktopNativeWidgetAura::SetShape(SkRegion* shape) {

+void DesktopNativeWidgetAura::SetShape(std::unique_ptr<SkRegion> shape) {

if (content_window_)

- desktop_window_tree_host_->SetShape(shape);

+ desktop_window_tree_host_->SetShape(std::move(shape));

}

void DesktopNativeWidgetAura::Close() {