ui/views/widget/native_widget_private.h - Issue 2173033002: Make various views SetShape() methods take an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/native_widget_private.h

Issue 2173033002: Make various views SetShape() methods take an unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/native_widget_private.h

diff --git a/ui/views/widget/native_widget_private.h b/ui/views/widget/native_widget_private.h

index 21f4f894102f7e3254395afd8d795f1e8008433b..7b3fb6d2ea53bc73602fa10b57f8316ce33ec54d 100644

--- a/ui/views/widget/native_widget_private.h

+++ b/ui/views/widget/native_widget_private.h

@@ -5,6 +5,7 @@

#ifndef UI_VIEWS_WIDGET_NATIVE_WIDGET_PRIVATE_H_

#define UI_VIEWS_WIDGET_NATIVE_WIDGET_PRIVATE_H_

+#include <memory>

#include <string>

#include "base/strings/string16.h"

@@ -177,7 +178,7 @@ class VIEWS_EXPORT NativeWidgetPrivate : public NativeWidget {

virtual void StackAbove(gfx::NativeView native_view) = 0;

virtual void StackAtTop() = 0;

virtual void StackBelow(gfx::NativeView native_view) = 0;

- virtual void SetShape(SkRegion* shape) = 0;

+ virtual void SetShape(std::unique_ptr<SkRegion> shape) = 0;

virtual void Close() = 0;

virtual void CloseNow() = 0;

virtual void Show() = 0;

« no previous file with comments | « ui/views/widget/native_widget_mac.mm ('k') | ui/views/widget/widget.h » ('j') | no next file with comments »