Add ${target}+bundle to ios_framework_bundle template.

Add ${target}+bundle to ios_framework_bundle template.

Usually iOS framework bundle will be included in an application
so have them define a ${target}+bundle target that can be used
to depend and cause the copy into the application bundle.

BUG=629867
Committed: https://crrev.com/effdadd7485ae1bf2361c8e3762761328fe1d581
Cr-Commit-Position: refs/heads/master@{#407129}

[sdefresne, 2016-07-21 18:15:54]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-07-21 18:16:14]

sdefresne@chromium.org changed reviewers:
+ justincohen@chromium.org

[sdefresne, 2016-07-21 18:16:15]

Please take a look.

[commit-bot: I haz the power, 2016-07-21 18:16:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[justincohen, 2016-07-21 18:34:51]

lgtm

https://codereview.chromium.org/2172733003/diff/1/build/config/ios/rules.gni
File build/config/ios/rules.gni (right):

https://codereview.chromium.org/2172733003/diff/1/build/config/ios/rules.gni#...
build/config/ios/rules.gni:897: if (!_is_fat_build || _is_fat_build_main_target)
{
I'm seeing `!_is_fat_build || _is_fat_build_main_target` all over the place.  Is
there a better bool / wrapper we could use here?

[commit-bot: I haz the power, 2016-07-21 18:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 18:50:00]

Dry run: Try jobs failed on following builders:
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[sdefresne, 2016-07-22 08:05:21]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 08:05:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:11:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:11:49]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-07-22 11:10:52]

On 2016/07/21 18:34:51, justincohen wrote:
> lgtm
> 
> https://codereview.chromium.org/2172733003/diff/1/build/config/ios/rules.gni
> File build/config/ios/rules.gni (right):
> 
>
https://codereview.chromium.org/2172733003/diff/1/build/config/ios/rules.gni#...
> build/config/ios/rules.gni:897: if (!_is_fat_build ||
_is_fat_build_main_target)
> {
> I'm seeing `!_is_fat_build || _is_fat_build_main_target` all over the place. 
Is
> there a better bool / wrapper we could use here?

Refactoring this would be tricky, and I need separate bools to make difference
between three states: thin build, primary architecture of a fat build, secondary
architecture of a fat build. I could use constants, but I'm not sure it would be
much simpler. Those conditions should be restricted to this file and
build/config/mac/base_rules.gni so mostly self contained.

I'll consider refactoring this in a followup CL if possible.

[sdefresne, 2016-07-22 11:15:40]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-07-22 11:15:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2172733003/#ps20001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-22 11:15:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 11:19:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-22 11:20:30]

Description was changed from

==========
Add ${target}+bundle to ios_framework_bundle template.

Usually iOS framework bundle will be included in an application
so have them define a ${target}+bundle target that can be used
to depend and cause the copy into the application bundle.

BUG=629867
==========

to

==========
Add ${target}+bundle to ios_framework_bundle template.

Usually iOS framework bundle will be included in an application
so have them define a ${target}+bundle target that can be used
to depend and cause the copy into the application bundle.

BUG=629867

Committed: https://crrev.com/effdadd7485ae1bf2361c8e3762761328fe1d581
Cr-Commit-Position: refs/heads/master@{#407129}
==========

[commit-bot: I haz the power, 2016-07-22 11:20:31]

Patchset 2 (id:??) landed as
https://crrev.com/effdadd7485ae1bf2361c8e3762761328fe1d581
Cr-Commit-Position: refs/heads/master@{#407129}