Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2167283002: Add missing dependencies to fix "gn check". (Closed)

Created:
4 years, 5 months ago by sdefresne
Modified:
4 years, 5 months ago
Reviewers:
justincohen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios-framework-bundle
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing dependencies to fix "gn check". BUG=629867 Committed: https://crrev.com/e93bb1dfa395b74621a86d189aa55691a6acc1e4 Cr-Commit-Position: refs/heads/master@{#407145}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/testing/earl_grey/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
sdefresne
Please take a look.
4 years, 5 months ago (2016-07-21 18:17:32 UTC) #3
justincohen
lgtm
4 years, 5 months ago (2016-07-21 18:35:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2167283002/20001
4 years, 5 months ago (2016-07-22 13:09:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 13:41:15 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 13:43:52 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e93bb1dfa395b74621a86d189aa55691a6acc1e4
Cr-Commit-Position: refs/heads/master@{#407145}

Powered by Google App Engine
This is Rietveld 408576698