[MD History] Close delete items dialog when a new query is initiated.

[MD History] Close delete items dialog when a new query is initiated.

This CL fixes an issue where the dialog in MD History would stay open
when the user pressed the Back button in the browser. As a catchall, the
dialog will now close when any non-incremental query is initiated.

BUG=630584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d639e4a5bc4f451b24917d19818eadf15d016095
Cr-Commit-Position: refs/heads/master@{#409472}

[calamity, 2016-07-28 01:26:40]

Description was changed from

==========
[MD History] Close delete items dialog when a new query is initiated.

This CL fixes an issue where the dialog in MD History would stay open
when the user pressed the Back button in the browser. As a catchall, the
dialog will now close when any non-incremental query is initiated.

BUG=630584
==========

to

==========
[MD History] Close delete items dialog when a new query is initiated.

This CL fixes an issue where the dialog in MD History would stay open
when the user pressed the Back button in the browser. As a catchall, the
dialog will now close when any non-incremental query is initiated.

BUG=630584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2016-07-28 01:40:54]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 01:41:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 01:49:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 01:49:06]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[calamity, 2016-07-28 03:15:05]

calamity@chromium.org changed reviewers:
+ tsergeant@chromium.org

[tsergeant, 2016-07-28 07:20:45]

https://codereview.chromium.org/2186073003/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/history_list_test.js (right):

https://codereview.chromium.org/2186073003/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/history_list_test.js:273:
registerMessageCallback('queryHistory', this, function() {});
Why is this necessary? Should we be doing this everywhere?

[calamity, 2016-08-01 02:46:11]

https://codereview.chromium.org/2186073003/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/history_list_test.js (right):

https://codereview.chromium.org/2186073003/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/history_list_test.js:273:
registerMessageCallback('queryHistory', this, function() {});
On 2016/07/28 07:20:45, tsergeant wrote:
> Why is this necessary? Should we be doing this everywhere?

The added test fails with cannot read property 'apply' of undefined, because
queryHistory does a chrome.send which just tried to call undefined.

This is only necessary because I want querying to not be disabled in that last
test, but I also didn't want to listen to it.

[tsergeant, 2016-08-01 02:52:27]

lgtm

[calamity, 2016-08-02 01:42:11]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2016-08-02 01:42:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 02:16:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 02:16:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[calamity, 2016-08-02 03:33:17]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 03:33:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 04:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 04:30:47]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-08-03 06:01:05]

The CQ bit was checked by calamity@chromium.org

[calamity, 2016-08-03 06:01:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org
Link to the patchset: https://codereview.chromium.org/2186073003/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-03 06:01:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 06:48:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-03 06:50:57]

Description was changed from

==========
[MD History] Close delete items dialog when a new query is initiated.

This CL fixes an issue where the dialog in MD History would stay open
when the user pressed the Back button in the browser. As a catchall, the
dialog will now close when any non-incremental query is initiated.

BUG=630584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD History] Close delete items dialog when a new query is initiated.

This CL fixes an issue where the dialog in MD History would stay open
when the user pressed the Back button in the browser. As a catchall, the
dialog will now close when any non-incremental query is initiated.

BUG=630584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d639e4a5bc4f451b24917d19818eadf15d016095
Cr-Commit-Position: refs/heads/master@{#409472}
==========

[commit-bot: I haz the power, 2016-08-03 06:50:58]

Patchset 2 (id:??) landed as
https://crrev.com/d639e4a5bc4f451b24917d19818eadf15d016095
Cr-Commit-Position: refs/heads/master@{#409472}