Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2172043002: chrome/browser/extensions: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, danakj, extensions-reviews_chromium.org, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chrome/browser/extensions: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=reillyg@chromium.org BUG=554600 Committed: https://crrev.com/ae72b08137e2ca7af8b3fef367af33be0866ef64 Cr-Commit-Position: refs/heads/master@{#407603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M chrome/browser/extensions/all_urls_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/dial/dial_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extension_web_contents_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_management.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-07-22 00:31:30 UTC) #1
Reilly Grant (use Gerrit)
lgtm, though the difficulty of reviewing this patch has somewhat convinced me of the evils ...
4 years, 5 months ago (2016-07-22 17:40:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172043002/1
4 years, 5 months ago (2016-07-25 21:12:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 21:56:01 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 21:57:38 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ae72b08137e2ca7af8b3fef367af33be0866ef64
Cr-Commit-Position: refs/heads/master@{#407603}

Powered by Google App Engine
This is Rietveld 408576698