chrome/browser/extensions/external_provider_impl.cc - Issue 2172043002: chrome/browser/extensions: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 2172043002: chrome/browser/extensions: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/permissions_based_management_policy_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_provider_impl.cc

diff --git a/chrome/browser/extensions/external_provider_impl.cc b/chrome/browser/extensions/external_provider_impl.cc

index 9d130940949ebedd0db51058603d2ca7b2a24129..9a7026cee52eebe755c1f24ece28f939cfe86648 100644

--- a/chrome/browser/extensions/external_provider_impl.cc

+++ b/chrome/browser/extensions/external_provider_impl.cc

@@ -127,10 +127,10 @@ void ExternalProviderImpl::SetPrefs(base::DictionaryValue* prefs) {

RetrieveExtensionsFromPrefs(&external_update_url_extensions,

&external_file_extensions);

- for (const auto& extension : external_update_url_extensions)

+ for (auto* extension : external_update_url_extensions)

service_->OnExternalExtensionUpdateUrlFound(*extension, true);

- for (const auto& extension : external_file_extensions)

+ for (auto* extension : external_file_extensions)

service_->OnExternalExtensionFileFound(*extension);

service_->OnExternalProviderReady(this);