Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: chrome/browser/extensions/external_provider_impl.cc

Issue 2172043002: chrome/browser/extensions: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/external_provider_impl.h" 5 #include "chrome/browser/extensions/external_provider_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <set> 9 #include <set>
10 #include <vector> 10 #include <vector>
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 if (!service_) return; 120 if (!service_) return;
121 121
122 prefs_.reset(prefs); 122 prefs_.reset(prefs);
123 ready_ = true; // Queries for extensions are allowed from this point. 123 ready_ = true; // Queries for extensions are allowed from this point.
124 124
125 ScopedVector<ExternalInstallInfoUpdateUrl> external_update_url_extensions; 125 ScopedVector<ExternalInstallInfoUpdateUrl> external_update_url_extensions;
126 ScopedVector<ExternalInstallInfoFile> external_file_extensions; 126 ScopedVector<ExternalInstallInfoFile> external_file_extensions;
127 127
128 RetrieveExtensionsFromPrefs(&external_update_url_extensions, 128 RetrieveExtensionsFromPrefs(&external_update_url_extensions,
129 &external_file_extensions); 129 &external_file_extensions);
130 for (const auto& extension : external_update_url_extensions) 130 for (auto* extension : external_update_url_extensions)
131 service_->OnExternalExtensionUpdateUrlFound(*extension, true); 131 service_->OnExternalExtensionUpdateUrlFound(*extension, true);
132 132
133 for (const auto& extension : external_file_extensions) 133 for (auto* extension : external_file_extensions)
134 service_->OnExternalExtensionFileFound(*extension); 134 service_->OnExternalExtensionFileFound(*extension);
135 135
136 service_->OnExternalProviderReady(this); 136 service_->OnExternalProviderReady(this);
137 } 137 }
138 138
139 void ExternalProviderImpl::UpdatePrefs(base::DictionaryValue* prefs) { 139 void ExternalProviderImpl::UpdatePrefs(base::DictionaryValue* prefs) {
140 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 140 CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
141 // We only expect updates from windows registry. 141 // We only expect updates from windows registry.
142 CHECK(crx_location_ == Manifest::EXTERNAL_REGISTRY); 142 CHECK(crx_location_ == Manifest::EXTERNAL_REGISTRY);
143 143
(...skipping 593 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 new ExternalProviderImpl( 737 new ExternalProviderImpl(
738 service, 738 service,
739 new ExternalComponentLoader(profile), 739 new ExternalComponentLoader(profile),
740 profile, 740 profile,
741 Manifest::INVALID_LOCATION, 741 Manifest::INVALID_LOCATION,
742 Manifest::EXTERNAL_COMPONENT, 742 Manifest::EXTERNAL_COMPONENT,
743 Extension::FROM_WEBSTORE | Extension::WAS_INSTALLED_BY_DEFAULT))); 743 Extension::FROM_WEBSTORE | Extension::WAS_INSTALLED_BY_DEFAULT)));
744 } 744 }
745 745
746 } // namespace extensions 746 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698