Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2171973005: Add test to check that the payment response details field is a JSON-serializable object. (Closed)

Created:
4 years, 5 months ago by pals
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add test to check that the payment response details field is a JSON-serializable object. BUG=587995 Committed: https://crrev.com/c0452d6b6cf1ba95c7449f84df149edfc639f2b7 Cr-Commit-Position: refs/heads/master@{#407415}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
pals
PTAL.
4 years, 5 months ago (2016-07-22 09:04:28 UTC) #3
please use gerrit instead
lgtm % nit https://codereview.chromium.org/2171973005/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp File third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp (right): https://codereview.chromium.org/2171973005/diff/1/third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp#newcode78 third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp:78: Remove this empty line. A typical ...
4 years, 5 months ago (2016-07-22 16:58:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171973005/20001
4 years, 5 months ago (2016-07-25 04:47:36 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-25 04:51:01 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 04:52:29 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0452d6b6cf1ba95c7449f84df149edfc639f2b7
Cr-Commit-Position: refs/heads/master@{#407415}

Powered by Google App Engine
This is Rietveld 408576698