Add test to check that the payment response details field is a JSON-serializable object.

third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentResponse.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/V8Binding.h"
@@ skipping 51 matching lines @@
 
     ASSERT_FALSE(scope.getExceptionState().hadException());
     ASSERT_TRUE(details.v8Value()->IsObject());
 
     ScriptValue transactionId(scope.getScriptState(), details.v8Value().As<v8::Object>()->Get(v8String(scope.getScriptState()->isolate(), "transactionId")));
 
     ASSERT_TRUE(transactionId.v8Value()->IsNumber());
     EXPECT_EQ(123, transactionId.v8Value().As<v8::Number>()->Value());
 }
 
+TEST(PaymentResponseTest, PaymentResponseDetailsJSONObject)
+{
+    V8TestingScope scope;
+    mojom::blink::PaymentResponsePtr input = buildPaymentResponseForTest();
+    input->stringified_details = "transactionId";
+    MockPaymentCompleter* completeCallback = new MockPaymentCompleter;
+

[please use gerrit instead, 2016/07/22 16:58:54]

Remove this empty line. A typical test has three sections:

1) setup
2) action under test
3) verification of results

Lines 74-79 are all for setup, so there's no need to place an empty line in this
block.

+    PaymentResponse output(std::move(input), completeCallback);
+
+    ScriptValue details = output.details(scope.getScriptState(), scope.getExceptionState());
+
+    ASSERT_TRUE(scope.getExceptionState().hadException());
+}
+
 TEST(PaymentResponseTest, CompleteCalledWithSuccess)
 {
     V8TestingScope scope;
     mojom::blink::PaymentResponsePtr input = buildPaymentResponseForTest();
     input->method_name = "foo";
     input->stringified_details = "{\"transactionId\": 123}";
     MockPaymentCompleter* completeCallback = new MockPaymentCompleter;
     PaymentResponse output(std::move(input), completeCallback);
 
     EXPECT_CALL(*completeCallback, complete(scope.getScriptState(), Success));
@@ skipping 10 matching lines @@
     MockPaymentCompleter* completeCallback = new MockPaymentCompleter;
     PaymentResponse output(std::move(input), completeCallback);
 
     EXPECT_CALL(*completeCallback, complete(scope.getScriptState(), Fail));
 
     output.complete(scope.getScriptState(), "fail");
 }
 
 } // namespace
 } // namespace blink