Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Side by Side Diff: third_party/WebKit/Source/modules/payments/PaymentResponseTest.cpp

Issue 2171973005: Add test to check that the payment response details field is a JSON-serializable object. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/payments/PaymentResponse.h" 5 #include "modules/payments/PaymentResponse.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/ScriptValue.h" 9 #include "bindings/core/v8/ScriptValue.h"
10 #include "bindings/core/v8/V8Binding.h" 10 #include "bindings/core/v8/V8Binding.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 62
63 ASSERT_FALSE(scope.getExceptionState().hadException()); 63 ASSERT_FALSE(scope.getExceptionState().hadException());
64 ASSERT_TRUE(details.v8Value()->IsObject()); 64 ASSERT_TRUE(details.v8Value()->IsObject());
65 65
66 ScriptValue transactionId(scope.getScriptState(), details.v8Value().As<v8::O bject>()->Get(v8String(scope.getScriptState()->isolate(), "transactionId"))); 66 ScriptValue transactionId(scope.getScriptState(), details.v8Value().As<v8::O bject>()->Get(v8String(scope.getScriptState()->isolate(), "transactionId")));
67 67
68 ASSERT_TRUE(transactionId.v8Value()->IsNumber()); 68 ASSERT_TRUE(transactionId.v8Value()->IsNumber());
69 EXPECT_EQ(123, transactionId.v8Value().As<v8::Number>()->Value()); 69 EXPECT_EQ(123, transactionId.v8Value().As<v8::Number>()->Value());
70 } 70 }
71 71
72 TEST(PaymentResponseTest, PaymentResponseDetailsJSONObject)
73 {
74 V8TestingScope scope;
75 mojom::blink::PaymentResponsePtr input = buildPaymentResponseForTest();
76 input->stringified_details = "transactionId";
77 MockPaymentCompleter* completeCallback = new MockPaymentCompleter;
78 PaymentResponse output(std::move(input), completeCallback);
79
80 ScriptValue details = output.details(scope.getScriptState(), scope.getExcept ionState());
81
82 ASSERT_TRUE(scope.getExceptionState().hadException());
83 }
84
72 TEST(PaymentResponseTest, CompleteCalledWithSuccess) 85 TEST(PaymentResponseTest, CompleteCalledWithSuccess)
73 { 86 {
74 V8TestingScope scope; 87 V8TestingScope scope;
75 mojom::blink::PaymentResponsePtr input = buildPaymentResponseForTest(); 88 mojom::blink::PaymentResponsePtr input = buildPaymentResponseForTest();
76 input->method_name = "foo"; 89 input->method_name = "foo";
77 input->stringified_details = "{\"transactionId\": 123}"; 90 input->stringified_details = "{\"transactionId\": 123}";
78 MockPaymentCompleter* completeCallback = new MockPaymentCompleter; 91 MockPaymentCompleter* completeCallback = new MockPaymentCompleter;
79 PaymentResponse output(std::move(input), completeCallback); 92 PaymentResponse output(std::move(input), completeCallback);
80 93
81 EXPECT_CALL(*completeCallback, complete(scope.getScriptState(), Success)); 94 EXPECT_CALL(*completeCallback, complete(scope.getScriptState(), Success));
(...skipping 10 matching lines...) Expand all
92 MockPaymentCompleter* completeCallback = new MockPaymentCompleter; 105 MockPaymentCompleter* completeCallback = new MockPaymentCompleter;
93 PaymentResponse output(std::move(input), completeCallback); 106 PaymentResponse output(std::move(input), completeCallback);
94 107
95 EXPECT_CALL(*completeCallback, complete(scope.getScriptState(), Fail)); 108 EXPECT_CALL(*completeCallback, complete(scope.getScriptState(), Fail));
96 109
97 output.complete(scope.getScriptState(), "fail"); 110 output.complete(scope.getScriptState(), "fail");
98 } 111 }
99 112
100 } // namespace 113 } // namespace
101 } // namespace blink 114 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698