Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2170973002: HRTF panner should handle the case of no loaded HRTF database (Closed)

Created:
4 years, 5 months ago by Raymond Toy
Modified:
4 years, 5 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HRTF panner should handle the case of no loaded HRTF database Currently, the panner node checks to see if the HRTF database is loaded and does the copy of the input if necessary. This is the wrong abstraction; the HRTF panner should copy the input if the database is not ready. In this way, the panner doesn't need to know about this implementation detail, and we also get the correct distance and cone gains applied. BUG=629858 TEST= Committed: https://crrev.com/d8bfaa0cd8383d9dff73c737fe8ae19fedc40a43 Cr-Commit-Position: refs/heads/master@{#406988}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -26 lines) Patch
M third_party/WebKit/Source/modules/webaudio/PannerNode.cpp View 1 3 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/EqualPowerPanner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFPanner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/HRTFPanner.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/Panner.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Raymond Toy
PTAL
4 years, 5 months ago (2016-07-21 21:06:16 UTC) #4
hongchan
lgtm
4 years, 5 months ago (2016-07-21 22:03:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170973002/20001
4 years, 5 months ago (2016-07-21 22:08:16 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 23:27:48 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:29:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d8bfaa0cd8383d9dff73c737fe8ae19fedc40a43
Cr-Commit-Position: refs/heads/master@{#406988}

Powered by Google App Engine
This is Rietveld 408576698