HRTF panner should handle the case of no loaded HRTF database

third_party/WebKit/Source/modules/webaudio/PannerNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 113 matching lines @@
     if (!source) {
         destination->zero();
         return;
     }
 
     // The audio thread can't block on this lock, so we call tryLock() instead.
     MutexTryLocker tryLocker(m_processLock);
     MutexTryLocker tryListenerLocker(listener()->listenerLock());
 
     if (tryLocker.locked() && tryListenerLocker.locked()) {
-        // HRTFDatabase should be loaded before proceeding when the panning model is HRTF.
-        if (m_panningModel == Panner::PanningModelHRTF && !listener()->isHRTFDatabaseLoaded()) {
-            if (context()->hasRealtimeConstraint()) {
-                // Realtime AudioContext's cannot block on the HRTFDatabase
-                // loader.  Instead, copy the input to the output so we can at
-                // least hear something until the database is ready.
-                destination->copyFrom(*source, m_channelInterpretation);
-                return;
-            }
-
+        if (!context()->hasRealtimeConstraint() && m_panningModel == Panner::PanningModelHRTF) {
+            // For an OfflineAudioContext, we need to make sure the HRTFDatabase
+            // is loaded before proceeding.  For realtime contexts, we don't
+            // have to wait.  The HRTF panner handles that case itself.
             listener()->waitForHRTFDatabaseLoaderThreadCompletion();
         }
 
         if (hasSampleAccurateValues() || listener()->hasSampleAccurateValues()) {
             // It's tempting to skip sample-accurate processing if isAzimuthElevationDirty() and
             // isDistanceConeGain() both return false.  But in general we can't because something
             // may scheduled to start in the middle of the rendering quantum.  On the other hand,
             // the audible effect may be small enough that we can afford to do this optimization.
             processSampleAccurateValues(destination, source, framesToProcess);
         } else {
             // Apply the panning effect.
             double azimuth;
             double elevation;
 
             // Update dirty state in case something has moved; this can happen if the AudioParam for
             // the position or orientation component is set directly.
             updateDirtyState();
 
             azimuthElevation(&azimuth, &elevation);
 
-            m_panner->pan(azimuth, elevation, source, destination, framesToProcess);
+            m_panner->pan(azimuth, elevation, source, destination, framesToProcess, internalChannelInterpretation());
 
             // Get the distance and cone gain.
             float totalGain = distanceConeGain();
 
             m_lastGain = totalGain;
 
             // Apply gain in-place with de-zippering.
             destination->copyWithGainFrom(*destination, &m_lastGain, totalGain);
         }
     } else {
@@ skipping 49 matching lines @@
         FloatPoint3D listenerForward(forwardX[k], forwardY[k], forwardZ[k]);
         FloatPoint3D listenerUp(upX[k], upY[k], upZ[k]);
 
         calculateAzimuthElevation(&azimuth[k], &elevation[k],
             pannerPosition, listenerPosition, listenerForward, listenerUp);
 
         // Get distance and cone gain
         totalGain[k] = calculateDistanceConeGain(pannerPosition, orientation, listenerPosition);
     }
 
-    m_panner->panWithSampleAccurateValues(azimuth, elevation, source, destination, framesToProcess);
+    m_panner->panWithSampleAccurateValues(azimuth, elevation, source, destination, framesToProcess, internalChannelInterpretation());
     destination->copyWithSampleAccurateGainValuesFrom(*destination, totalGain, framesToProcess);
 }
 
 void PannerHandler::initialize()
 {
     if (isInitialized())
         return;
 
     m_panner = Panner::create(m_panningModel, sampleRate(), listener()->hrtfDatabaseLoader());
     listener()->addPanner(*this);
@@ skipping 537 matching lines @@
     visitor->trace(m_positionZ);
 
     visitor->trace(m_orientationX);
     visitor->trace(m_orientationY);
     visitor->trace(m_orientationZ);
 
     AudioNode::trace(visitor);
 }
 
 } // namespace blink